This repository was archived by the owner on Nov 4, 2021. It is now read-only.
Cover action matching with tests moar - #478
Merged
Merged
Conversation
Twixes
marked this pull request as ready for review
June 18, 2021 11:27
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
…-server#478) * Various small improvements * Add a bunch more tests and fix other edge cases * Test cohort matching * Polish selector matching up * Add person prop + element href, text, tag, and selector tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #467.
Checklist
Updated Settings section in README.md, if settings are affected