This repository was archived by the owner on Nov 4, 2021. It is now read-only.
Build healthcheck into index.js - #455
Merged
Merged
Conversation
yakkomajuri
approved these changes
Jun 3, 2021
yakkomajuri
reviewed
Jun 3, 2021
| status.error('😡', 'Redis error encountered! Enough of this, I quit!\n', error) | ||
| killGracefully() | ||
| } else { | ||
| status.error('🔴', 'Redis error encountered! Trying to reconnect...\n', error) |
Contributor
There was a problem hiding this comment.
The only "nit" (it's not even that) I'd have is that this could tell me how many more retries to connect it'll perform. Might not even be super useful though.
Contributor
Author
There was a problem hiding this comment.
I'll table that for now
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
…r#455) * Build healthcheck into index.js * Add "Alternative modes" to README * Fix uncaught reject in Sentry flush
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #372. This way healthcheck is ran with the same executable as the usual mode of the plugin server:
posthog-plugin-server --healtcheck.Checklist