This repository was archived by the owner on Nov 4, 2021. It is now read-only.
S3 Job Queue - #399
Merged
Merged
S3 Job Queue#399
Conversation
Closed
mariusandra
marked this pull request as ready for review
May 25, 2021 20:55
mariusandra
force-pushed
the
new-job-queues
branch
from
May 26, 2021 09:38
23bb870 to
5ca2384
Compare
Collaborator
Author
|
Here's something that could use a look. :) I grouped the different job queues into folders based on functionality (local, concurrent, redlocked), but didn't yet implement different functionalities depending on the type. This means currently all job queues are still redlocked. I'd suggest tackling this in another PR. |
mariusandra
enabled auto-merge (squash)
May 26, 2021 15:15
neilkakkar
reviewed
May 26, 2021
| } | ||
| const date = new Date(retry.timestamp).toISOString() | ||
| const [day, time] = date.split('T') | ||
| const dayTime = `${day.split('-').join('')}-${time.split(':').join('')}` |
Contributor
There was a problem hiding this comment.
was there a specific reason for formatting things like this?
Collaborator
Author
There was a problem hiding this comment.
Basically just keeping it sortable to the second while removing special symbols that might interfere with it being a filename.
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
* store job queues with metadata * basic S3 queue * simplify job queues, create s3 wrapper * test all parts of the s3 queue before connecting * test s3 queue * prettier * fix timeout that ran just once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checklist