Skip to content

fix: hourly retention backups warning message about default RETENTION_CRON - #450

Merged
RambokDev merged 1 commit into
mainfrom
fix/hourly-gfs
Aug 10, 2026
Merged

fix: hourly retention backups warning message about default RETENTION_CRON#450
RambokDev merged 1 commit into
mainfrom
fix/hourly-gfs

Conversation

@RambokDev

@RambokDev RambokDev commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added a warning beneath the hourly GFS retention setting when hourly retention is enabled.
    • Included guidance about the default daily retention schedule and a link to environment-variable documentation.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The retention policy form now shows scheduling guidance below the hourly GFS retention field when hourly retention is enabled. The warning explains the daily default RETENTION_CRON schedule and links to environment-variable documentation in a new tab.

Changes

Retention scheduling guidance

Layer / File(s) Summary
Hourly retention warning
src/features/database/components/retention-policy-form.tsx
The form conditionally displays RETENTION_CRON guidance and an external documentation link for enabled hourly retention tiers.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: official-krish

Poem

A rabbit spots the hourly sign,
“Check RETENTION_CRON timing fine.”
A daily schedule may not suffice,
So docs open with a click precise.
Hop, hop—retention’s clear tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the warning added for hourly retention backups and the default RETENTION_CRON setting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/hourly-gfs

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/features/database/components/retention-policy-form.tsx

Oops! Something went wrong! :(

ESLint: 10.8.0

TypeError [ERR_IMPORT_ATTRIBUTE_MISSING]: Module "file:///.eslintrc.json?mtime=1785870776471" needs an import attribute of "type: json"
at validateAttributes (node:internal/modules/esm/assert:88:15)
at defaultLoadSync (node:internal/modules/esm/load:164:3)
at #loadAndMaybeBlockOnLoaderThread (node:internal/modules/esm/loader:776:12)
at #loadSync (node:internal/modules/esm/loader:796:49)
at ModuleLoader.load (node:internal/modules/esm/loader:762:26)
at ModuleLoader.loadAndTranslate (node:internal/modules/esm/loader:504:31)
at #getOrCreateModuleJobAfterResolve (node:internal/modules/esm/loader:555:36)
at afterResolve (node:internal/modules/esm/loader:603:52)
at ModuleLoader.getOrCreateModuleJob (node:internal/modules/esm/loader:609:12)
at node:internal/modules/esm/loader:628:32


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/features/database/components/retention-policy-form.tsx`:
- Around line 262-266: Update the warning text near RETENTION_CRON in the
retention policy form to qualify the daily schedule as the production default,
without implying that development uses the same schedule. Preserve the existing
guidance and documentation link.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b77c2ec9-1c3e-4549-9649-88c11dc50360

📥 Commits

Reviewing files that changed from the base of the PR and between a71b69e and 661c887.

📒 Files selected for processing (1)
  • src/features/database/components/retention-policy-form.tsx
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: build-image
  • GitHub Check: plumber
  • GitHub Check: Analyze (javascript-typescript)

Comment thread src/features/database/components/retention-policy-form.tsx
@RambokDev
RambokDev merged commit 07c8272 into main Aug 10, 2026
9 checks passed
@RambokDev
RambokDev deleted the fix/hourly-gfs branch August 10, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant