fix: hourly retention backups warning message about default RETENTION_CRON - #450
Conversation
📝 WalkthroughWalkthroughThe retention policy form now shows scheduling guidance below the hourly GFS retention field when hourly retention is enabled. The warning explains the daily default ChangesRetention scheduling guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/features/database/components/retention-policy-form.tsxOops! Something went wrong! :( ESLint: 10.8.0 TypeError [ERR_IMPORT_ATTRIBUTE_MISSING]: Module "file:///.eslintrc.json?mtime=1785870776471" needs an import attribute of "type: json" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/database/components/retention-policy-form.tsx`:
- Around line 262-266: Update the warning text near RETENTION_CRON in the
retention policy form to qualify the daily schedule as the production default,
without implying that development uses the same schedule. Preserve the existing
guidance and documentation link.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b77c2ec9-1c3e-4549-9649-88c11dc50360
📒 Files selected for processing (1)
src/features/database/components/retention-policy-form.tsx
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: build-image
- GitHub Check: plumber
- GitHub Check: Analyze (javascript-typescript)
Summary by CodeRabbit