Skip to content

fix: s3 logs - #93

Merged
RambokDev merged 1 commit into
mainfrom
fix/s3-storage
Jul 26, 2026
Merged

fix: s3 logs#93
RambokDev merged 1 commit into
mainfrom
fix/s3-storage

Conversation

@RambokDev

@RambokDev RambokDev commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility with S3-compatible storage services during multipart uploads.
    • Prevented unsupported automatic checksum requests from causing upload failures.
    • Enhanced multipart upload error messages with more detailed diagnostic information.

@RambokDev
RambokDev merged commit de106c8 into main Jul 26, 2026
1 of 2 checks passed
@RambokDev
RambokDev deleted the fix/s3-storage branch July 26, 2026 09:04
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e8c7340-6ffa-4fb1-a4e1-c4fe4438b592

📥 Commits

Reviewing files that changed from the base of the PR and between fe1d749 and 23d6822.

📒 Files selected for processing (1)
  • src/services/storage/providers/s3/mod.rs

📝 Walkthrough

Walkthrough

The S3 provider now disables automatic checksum calculation unless required and uses detailed SDK error contexts for multipart upload creation, part upload, and completion failures.

Changes

S3 multipart upload updates

Layer / File(s) Summary
Conditional checksum configuration
src/services/storage/providers/s3/mod.rs
The S3 client sets request checksum calculation to WhenRequired for S3-compatible multipart endpoints.
Detailed multipart error reporting
src/services/storage/providers/s3/mod.rs
Multipart creation, part upload, and completion failures derive detailed error strings for logs and UploadResult.error.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/s3-storage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant