fix: windows-build - #92
Conversation
📝 WalkthroughWalkthroughThe release workflow now builds Windows artifacts through a reusable workflow before finalization. Production Compose builds the application locally and exposes Docker connectivity, while Docker client initialization uses default connection settings and the configured edge key changes. ChangesRelease and runtime integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CreateRelease
participant WindowsBuild
participant GitHubRelease
participant FinalizeRelease
CreateRelease->>WindowsBuild: pass version, ref, and draft_tag
WindowsBuild->>WindowsBuild: build and package Windows executable
WindowsBuild->>GitHubRelease: upload asset when draft_tag is set
WindowsBuild->>FinalizeRelease: complete build job
FinalizeRelease->>FinalizeRelease: finalize after required publishing jobs
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/windows-release.yml:
- Around line 94-100: Update the “Attach asset to draft release” step so the
draft tag and prepared zip path are passed through step-level env variables
rather than interpolated directly in the PowerShell command. Reference those
environment variables in the gh release upload invocation, preserving the
existing clobber behavior and GH_TOKEN configuration.
In `@docker-compose.prod.yml`:
- Around line 9-11: Remove the direct /var/run/docker.sock mount from the
rust-prod volumes and move helper-container cleanup outside the application
container, or replace the socket dependency with a narrowly scoped Docker API
proxy that exposes only the required cleanup operations.
In `@docker-compose.yml`:
- Line 24: Remove the hardcoded EDGE_KEY value from the Compose environment and
replace it with runtime environment injection, such as referencing an externally
supplied EDGE_KEY variable. Rotate and revoke the exposed credential, and ensure
src/settings.rs continues reading the injected value without embedding a
fallback secret.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 30f2f620-95b5-4ff6-a185-e181164da9e9
📒 Files selected for processing (5)
.github/workflows/release.yml.github/workflows/windows-release.ymldocker-compose.prod.ymldocker-compose.ymlsrc/domain/docker_volume/docker.rs
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary by CodeRabbit
New Features
Bug Fixes
Deployment