Skip to content

fix: windows-build - #92

Merged
RambokDev merged 2 commits into
mainfrom
fix/windows-build
Jul 25, 2026
Merged

fix: windows-build#92
RambokDev merged 2 commits into
mainfrom
fix/windows-build

Conversation

@RambokDev

@RambokDev RambokDev commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Windows builds are now included in the release process and can be attached to draft releases.
    • Windows release workflows support both automated and manual builds for selected versions or references.
  • Bug Fixes

    • Improved Docker daemon connectivity across supported environments.
  • Deployment

    • Production deployments can build the application image locally.
    • Added Docker socket access and external network configuration for improved container integration.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The release workflow now builds Windows artifacts through a reusable workflow before finalization. Production Compose builds the application locally and exposes Docker connectivity, while Docker client initialization uses default connection settings and the configured edge key changes.

Changes

Release and runtime integration

Layer / File(s) Summary
Reusable Windows release pipeline
.github/workflows/windows-release.yml
The workflow accepts release inputs, builds with the MSVC toolchain, caches dependencies, packages the executable, uploads the artifact, and optionally attaches it to a draft release.
Release finalization wiring
.github/workflows/release.yml
Release creation now invokes the Windows workflow, and finalization waits for the Windows build alongside existing publishing jobs.
Docker deployment and daemon connectivity
docker-compose.prod.yml, docker-compose.yml, src/domain/docker_volume/docker.rs
Production Compose builds the application image locally, mounts the Docker socket, defines the external network, updates EDGE_KEY, and connects to Docker using default settings.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CreateRelease
  participant WindowsBuild
  participant GitHubRelease
  participant FinalizeRelease
  CreateRelease->>WindowsBuild: pass version, ref, and draft_tag
  WindowsBuild->>WindowsBuild: build and package Windows executable
  WindowsBuild->>GitHubRelease: upload asset when draft_tag is set
  WindowsBuild->>FinalizeRelease: complete build job
  FinalizeRelease->>FinalizeRelease: finalize after required publishing jobs
Loading

Possibly related PRs

  • Portabase/agent#23 — Updates the release orchestration that this change extends with Windows builds.
  • Portabase/agent#26 — Defines the create-release outputs consumed by the new Windows build job.
  • Portabase/agent#63 — Implements related Windows release workflow behavior.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main theme of the changes, which center on Windows build/release workflow updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/windows-release.yml:
- Around line 94-100: Update the “Attach asset to draft release” step so the
draft tag and prepared zip path are passed through step-level env variables
rather than interpolated directly in the PowerShell command. Reference those
environment variables in the gh release upload invocation, preserving the
existing clobber behavior and GH_TOKEN configuration.

In `@docker-compose.prod.yml`:
- Around line 9-11: Remove the direct /var/run/docker.sock mount from the
rust-prod volumes and move helper-container cleanup outside the application
container, or replace the socket dependency with a narrowly scoped Docker API
proxy that exposes only the required cleanup operations.

In `@docker-compose.yml`:
- Line 24: Remove the hardcoded EDGE_KEY value from the Compose environment and
replace it with runtime environment injection, such as referencing an externally
supplied EDGE_KEY variable. Rotate and revoke the exposed credential, and ensure
src/settings.rs continues reading the injected value without embedding a
fallback secret.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 30f2f620-95b5-4ff6-a185-e181164da9e9

📥 Commits

Reviewing files that changed from the base of the PR and between c9725c3 and 0ef4bba.

📒 Files selected for processing (5)
  • .github/workflows/release.yml
  • .github/workflows/windows-release.yml
  • docker-compose.prod.yml
  • docker-compose.yml
  • src/domain/docker_volume/docker.rs

Comment thread .github/workflows/windows-release.yml
Comment thread docker-compose.prod.yml
Comment thread docker-compose.yml
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@RambokDev
RambokDev merged commit 424a646 into main Jul 25, 2026
3 checks passed
@RambokDev
RambokDev deleted the fix/windows-build branch July 25, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant