fix: firebird

[RambokDev]

Summary by CodeRabbit

• New Features

  • Added a large-scale Firebird data seeding option for creating substantial test datasets.
  • Added reporting of seeded record counts and total payload size.

• Improvements

  • Firebird backups now use garbage collection options to help produce cleaner, more reliable backup files.
  • Release finalization now waits for container image publishing to complete before proceeding.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 25e3a1ea-795a-4786-be71-d52dc18ab41a

📥 Commits

Reviewing files that changed from the base of the PR and between 54cfd67 and 80b1c0d.

📒 Files selected for processing (4)

• .github/workflows/release.yml
• justfile
• scripts/firebird/seed-large.sql
• src/domain/firebird/backup.rs

---

📝 Walkthrough

Walkthrough

The release workflow now waits for GHCR Docker publishing before finalization. Firebird tooling adds a large dataset seed script and recipe, and the backup command passes an additional gbak option.

Changes

Release workflow ordering

Layer / File(s)	Summary
Finalize release prerequisite .github/workflows/release.yml	finalize-release now depends on publish-docker-ghcr before running.

Firebird data and backup tooling

Layer / File(s)	Summary
Large Firebird seeding justfile, scripts/firebird/seed-large.sql	Adds a recipe and SQL script that create and populate users with generated BLOB payloads across committed batches, then report aggregate totals.
Firebird backup invocation src/domain/firebird/backup.rs	Adds the -g argument to the gbak command.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant just as just recipe
  participant isql
  participant seed as seed-large.sql
  participant Firebird
  just recipe->>isql: Execute large seed script
  isql->>seed-large.sql: Run schema and procedure statements
  seed-large.sql->>Firebird: Insert generated users and BLOB payloads
  seed-large.sql->>Firebird: Commit each batch
  isql->>Firebird: Query user count and payload size

Loading

Possibly related PRs

• Portabase/agent#23: Both modify release workflow dependencies around finalization.
• Portabase/agent#55: Both modify Firebird seeding and verification logic.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is related to Firebird changes, but it is too vague to convey the main fix or scope of the PR.	Rename it to summarize the primary Firebird change, such as the large seed script, backup flag update, or release workflow fix.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/firebird

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!