feat: Updated for podman support - #82
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe development setup now supports Docker and Podman, configurable container sockets, engine-specific Compose orchestration, external resource provisioning, and Podman container ID extraction. Environment templates, setup documentation, and Redis readiness checks were also updated. ChangesPodman-compatible development runtime
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Developer
participant app-dev-entrypoint.sh
participant ContainerEngine
participant Compose
participant Services
Developer->>app-dev-entrypoint.sh: start development environment
app-dev-entrypoint.sh->>ContainerEngine: detect Docker or Podman
app-dev-entrypoint.sh->>ContainerEngine: inspect or create network and volume
app-dev-entrypoint.sh->>Compose: resolve and invoke Compose
Compose->>Services: stop databases and start service stack
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Asuniia
left a comment
There was a problem hiding this comment.
pls remove all comments in your code
| EDGE_KEY: "eyJzZXJ2ZXJVcmwiOiJodHRwOi8vbG9jYWxob3N0Ojg4ODciLCJhZ2VudElkIjoiZWZhYTM0YTQtZDY1NC00OGQ3LTgwNDYtNjRkMWExYTA1M2FlIiwibWFzdGVyS2V5QjY0IjoiMUh0djdtWCtYVkJxL0IzUEV2WDlZZjlQeUdVZW5oRHlXemo5THRqNW90WT0ifQ==" | ||
| # Reach the container-local Redis by IP; "localhost" is remapped to the | ||
| # host by the extra_hosts entry below, which would break the connection. | ||
| CELERY_BROKER_URL: "redis://127.0.0.1:65515/" |
Adding support for Podman into the Portabase Agent; appears this is all that is needed to get volume support going!
I also updated the contrib doc as it was missing chunks (reference to stuff in readme that ... wasnt there)
I presume to properly close Portabase/portabase#391, there will need to be a companion update to the cli to detect podman client as well as docker?
Summary by CodeRabbit
New Features
Bug Fixes
Documentation