fix: pgdump-cluster - #68
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The legacy_tmp_dir Option was assigned-but-never-read, tripping unused_variables/unused_assignments. Replace the mut + reassignment with a bind-once (PathBuf, Option<TempDir>) tuple so the TempDir is still held for RAII through pg_restore, with no warnings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PostgresDumpFormat re-export is consumed only by the in-crate test suite; guard it with cfg_attr(not(test), allow(unused_imports)) so production cargo build stays warning-free. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replaced by the upcoming postgresql-cluster (pg_dumpall) mode. Reverts the include_globals bundle/globals system to the pre-feature baseline.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…atabase)
Move the single cluster.rs + cluster_database.rs into a cluster/ folder:
- cluster/backup.rs (run = pg_dumpall)
- cluster/restore.rs (run = psql replay)
- cluster/database.rs (PostgresClusterDatabase trait impl)
- cluster/mod.rs
Free fns renamed to run() to match postgres/{backup,restore}.rs convention.
No behavior change; cluster tests pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Split the flat postgres_cluster.rs into a cluster/ test module matching the src/domain/postgres/cluster/ layout: - cluster/backup.rs (produces_sql, requires_superuser) - cluster/restore.rs (round_trip_preserves_ownership, requires_superuser — new) - cluster/database.rs (factory routing -> .sql, no container) - cluster/mod.rs (shared start_cluster/env_for helpers) Adds restore-side superuser pre-check coverage and fast no-container factory routing tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
RambokDev
added a commit
that referenced
this pull request
Jun 27, 2026
* fix: pgdump-cluster (#68) * feat: add as_str/from_str to PostgresDumpFormat * feat: resolve pg_dumpall/psql binary names * feat: add include_globals field to database config * feat: add pg_dumpall/psql globals dump and apply * feat: add postgres backup bundle (manifest + build + resolve) * feat: bundle globals into postgres backup when include_globals is set * feat: replay globals before pg_restore when backup archive is a bundle * refactor: bind FD restore tempdir guard once to clear unused warnings * docs: demonstrate include_globals in sample databases.json * chore: silence test-only re-export warning in non-test builds * revert: remove include_globals feature, restore plain pg_dump/pg_restore * feat: add pg_dumpall/psql binary names and is_superuser check * feat: add postgresql-cluster db type and config parsing * feat: pg_dumpall cluster backup and psql restore * feat: route postgresql-cluster through PostgresClusterDatabase * docs: add postgresql-cluster sample to databases.json * refactor: split cluster mode into cluster/ module (backup, restore, database) * test: mirror cluster tests into src/tests/domain/cluster/ * feat: add-gcs-storage-provider (#70) * fix: refactoring * chore: add google-cloud-storage and google-cloud-auth deps * feat: add GCS provider config model * feat: add GCS credential, client, and stream-source helpers StreamSource bridges build_stream's Send-only byte stream into the SDK's StreamingSource (which send_buffered requires to be Send+Sync+'static) via a bounded mpsc channel, avoiding any change to the shared UploadStream type. * feat: implement GCS StorageProvider upload * feat: register google-cloud-storage provider in factory * test: GCS upload roundtrip against fake-gcs-server * fix: format GCS bucket as projects/_/buckets/<name> in upload_with_client write_object rejects the bare bucket id with "malformed bucket name"; the production provider passed config.bucket_name unformatted, so real uploads would always fail. Format once in upload_with_client so prod and the fake-gcs-server test share the corrected path. * style: cargo fmt GCS provider files * fix: gcs * fix: azure (#71)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.