feat(harness): add plan-level closed-unmerged scenario (AB#3239) - #482
Merged
PolyphonyRequiem merged 1 commit intoMay 19, 2026
Merged
Conversation
First path-coverage scenario for plan-level.yaml. Mirrors the github-pr abort-path template: state_detector classifies the plan PR as `awaiting_review` so the workflow enters the sentiment-loop seam, then poll_status reports `route=abort_unmerged`. The workflow surfaces `closed_unmerged_gate` (auto-acknowledged under --skip-gates) and terminates, proving the abort path is wired through the entire entry chain (depth_guard → guidance_loader → root_resolver → type_loader → ancestor_chain → state_detector → pr_poll_platform_router → poll_status → closed_unmerged_gate). Path covered: depth_guard → guidance_loader → root_resolver → type_loader → ancestor_chain → state_detector (awaiting_review) → pr_poll_platform_router (platform=github) → poll_status (route=abort_unmerged) → closed_unmerged_gate → \ No sequencing required — single-pass abort. Follow-up scenarios for the analyzer → fixer → merge loop, stale-generation re-architect, and complete-path child recursion will land separately. Refs AB#3239. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PolyphonyRequiem
deleted the
feat/ab3239-plan-level-closed-unmerged-scenario
branch
May 19, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First path-coverage scenario for
plan-level.yaml. Closes the immediateacceptance criterion of AB#3239 ("at least one passing scenario exercising
a plan-level sentiment-loop path"). Lands the simplest such path — the
closed-unmerged abort — and establishes the input/cli-stub baseline that
follow-up scenarios (analyzer → fixer → merge loop, stale-generation
re-architect, complete-path child recursion) can build on.
Path covered
The scenario stubs the seven entry-chain CLI verbs (
plan depth-guard,plan load-agent-guidance,root resolve,plan load-type,plan derive-ancestor-chain,plan detect-state,pr poll-status) with theminimum JSON each agent's Jinja templates inspect.
pr_poll_platform_routeris a pwsh inline script that runs unintercepted and routes on
workflow.input.platform.Single-pass abort — no shim sequencing required.
Verification
python -m driver.run tests/harness/scenarios/plan_level_closed_unmerged_acknowledges_via_gate→passed: true(event_count=37, gates_presented=[closed_unmerged_gate]).Invoke-Pester tests/harness/run-scenarios.Tests.ps1→ 11/11 green (10 existing + 1 new) in ~3m30s.Scope notes
This PR ships the closed-unmerged abort path only. The richer sentiment-loop
scenarios listed in AB#3239's "Scenarios to add" section remain in scope for
follow-up PRs but are intentionally not bundled here — each one needs its own
agent_scripts (architect, plan_reviewer, pr_feedback_analyzer, pr_fixer) and
in some cases shim sequencing, which makes them substantially larger reviews.
Splitting them out keeps each change reviewable.
Refs AB#3239.