v2.4.1: Permissive ADO approval aggregation (allow_any_approval_vote)

[PolyphonyRequiem]

Problem

ADO PRs that polyphony opens (plan PR, feature PR) have no required-reviewer branch policy configured. AdoClient.AggregateReviewDecision only returns APPROVED when requiredCount > 0 && requiredApproved == requiredCount — so even a +10 vote from the operator falls through to REVIEW_REQUIRED, the workflow loops back to pending_review_gate, and the apex item is un-mergeable through the normal flow.

Observed live on apex 62286666 — operator clicks Approve (+10) in the PR UI, clicks Continue on the gate, the next poll returns state: pending, reasons: ["state is pending"], the gate fires again. The advertised escape ("Approve (+5 or +10) — workflow merges next poll") is a promise the logic cannot keep.

Fix

Add an opt-in permissive aggregation mode gated by a new CLI flag, fed from a new policy field.

\\csharp
if (anyRejection) return "REJECTED"; // unchanged
if (requiredCount > 0 && requiredApproved == requiredCount) return "APPROVED";
if (allowAnyApprovalVote && anyApprovalVote) return "APPROVED"; // NEW
return "REVIEW_REQUIRED";
\\

• Rejection (-10) still shortcircuits — operators retain a hard veto.
• Default is false — strict ADO branch-policy semantics preserved for all consumers that have not opted in.
• The cloudvault dogfood writes pr.defaults.allow_any_approval_vote: true to its .polyphony-config/policy.yaml.

Scope

In scope: plan-level.yaml poll_status_ado. Other PR kinds (impl, feature, evidence via ado-pr.yaml) continue using strict aggregation regardless of the flag — PR-kind-aware schema (pr.allow_any_approval_vote.by_kind) is the proper long-term fix and is deferred.

Stale-approval caveat

ADO does NOT auto-invalidate reviewer votes on new commits (unlike GitHub dismiss_stale_reviews). With this flag enabled, an approval cast before a force push will still count after the push. Documented in the policy field XML doc and the gate prompt. SHA-bound approval semantics are tracked under AB#3104 PR2.

Wiring

• IAdoClient — new GetPullRequestPollDataAsync overload with the bool flag; default-interface-method delegates to the strict overload so the 19 FakeAdoClients across the suite don't break.
• polyphony pr poll-status-ado — new --allow-any-approval-vote CLI flag.
• Pr.Defaults.AllowAnyApprovalVote — new policy field with extensive XML doc covering the stale-approval caveat.
• plan-level.yaml — new pr_approval_policy_ado resolver step before poll_status_ado; pending_review_gate prompt rewritten with conditional permissive/strict messaging.

Tests

• 7 new AggregateReviewDecision cases (strict-mode regression + permissive-mode behaviour).
• 2 PollStatusAdo flag-threading cases (default false + opt-in true).
• 2 PolicyResolver allow_any_approval_vote cases (default false / dogfood override).
• Golden-test update for the new verb input.
• Lint fixture (tests/lint/fixtures/verb-output-schemas.json) surgically extended with the new input + the new ResolvedRule field — no blind regeneration; preserves Move feat: Phase Detection, Routing Engine, and Command Implementations (PG-3) AB#2593 AB#2594 #2 hand-curation per the fixture convention.

Version

Patch bump 2.4.0 → 2.4.1 across all 14 workflow YAMLs + the index.yaml versions arrays. min_polyphony_version: 2.4.1 in plan-level.yaml so older binaries fail preflight loudly if they encounter the new flag.

Verification

Local: dotnet test 3697 passed (4 flakes in cross-process tests passed on isolated re-run), lint-jinja-resolver + lint-version-drift Pester suites 46/46 green.

Dogfood: tag v2.4.1, install via ~/.polyphony/bin/install.ps1, write pr.defaults.allow_any_approval_vote: true to cloudvault, click Continue on the still-open gate of apex 62286666 — expect state=approved → route=merge_now → merges.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com