merge group pg-3166 for root #3166 - #373
Merged
Merged
Conversation
Add deterministic scope_empty_mg_triage node between scope_guidance_loader and scope_reviewer to distinguish three zero-commit MG cases: - Case A (structural_violation): genuinely empty MG — upstream bug - Case B (zero_commits_unresolved): deferred to scope_reviewer with enriched context for ADO-based evaluation - Case C (already_satisfied): fix already on main, auto-approved via scope_auto_approve node Previously all three collapsed to changes_requested, causing infinite revise loops that hit the scope_revise_cap_gate with no convergence path. Changes: - Add scope_empty_mg_triage script node with deterministic git checks (branch existence, task count, commit count, merge-base ancestry) - Add scope_auto_approve script node for Case C auto-approval - Update scope_reviewer prompt: keep structural checks (a)/(b), add zero-commit disambiguation section for Case A vs B - Update user_acceptance prompt to handle both scope_reviewer and scope_auto_approve feedback paths - Update lint tests (47 tests, all passing) Co-authored-by: Daniel Green <dangreen@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge group
pg-3166for root #3166Promotes
mg/3166_pg-3166intofeature/3166.This PR was opened by
polyphony pr open-mg-pr. The detailed body — including the manifest of items in this merge group — is composed by the orchestrating workflow when it has that context.