ci: re-enable Integration harness scenarios on PR CI (AB#3163) - #359
Merged
Conversation
The architect_research_loop harness scenario covers the exact broken path AB#3156 introduced via PR #351, but `Integration` was in ci.yml's Pester ExcludeTag — letting both bugs ship and burning two AB#3127 dogfood relaunches today. Removes `Integration` from the filter; harness now runs on every PR build. Part of AB#3158 (Convert prose conventions to typed enforcement). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
architect_research_loopharness scenario covers the exact broken path AB#3156 introduced via PR #351 — butIntegrationwas inci.yml's PesterExcludeTag, so the harness never ran on PR. Two bugs (AB#3156 + AB#3157) shipped through that gap and burned two AB#3127 dogfood relaunches today.What
Integrationfrom$config.Filter.ExcludeTagin.github/workflows/ci.yml(theSlowtag stays).tests/harness/README.mdto list the four scenarios actually shipping today (it still claimed two) and call out which scenario covers which regression.What the harness now catches on every PR
All four scenarios run as part of the
Test (Pester)job:close_out_happy_path—close-out.yamlend-to-end.cascade_remedy_no_stale—cascade-remedy.yamlno-stale path; exercises both the agent-provider seam and the .NET shim PATH seam.research_happy_path— research sub-workflow round-trip.architect_research_loop— architect → research → architect re-entry; the scenario that would have caught AB#3156 before PR feat: AB#3131 Research-augmented planning cycle #351 shipped.Verification
Local
Invoke-Pester -Path tests/harness/run-scenarios.Tests.ps1 -Output Detailed— all four scenarios pass; total wall clock ~2 min.Part of AB#3158 (Convert prose conventions to typed enforcement). Closes AB#3163.