🐛 Fix benchmarks#243
Merged
Merged
Conversation
vstam1
approved these changes
Apr 17, 2024
lrazovic
approved these changes
Apr 17, 2024
lrazovic
left a comment
lrazovic
left a comment
Member
There was a problem hiding this comment.
LGTM! Approved with one minor question
| //! Polimec Testnet chain specification | ||
|
|
||
| use cumulus_primitives_core::ParaId; | ||
| use frame_benchmarking::__private::traits::fungible::Inspect; |
Member
There was a problem hiding this comment.
Why Inspect is coming from frame_benchmarking and not from frame_support::traits::tokens::fungible::Inspect?
Contributor
Author
There was a problem hiding this comment.
oops, auto import crapped out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
just dry-run-benchmarksHow?
Testing?
just dry-run-benchmarksand see if no errors pops up