Enable staging deployment#10
Merged
Merged
Conversation
This was referenced May 2, 2020
phalt
approved these changes
May 10, 2020
sargunv
approved these changes
May 10, 2020
Member
sargunv
left a comment
There was a problem hiding this comment.
LGTM! For the future, it might be worth moving this stuff into GitHub Actions from CircleCI just to consolidate it all into one platform, but that's def not a blocker for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables a conditional deploy job on CircleCI so that we will have a productive environment and a staging one. This will allow us to check all the APIs and the website in a separate environment, and, if everything seems right, to deploy safely to https://pokeapi.co/.
A more descriptive and general overview is detailed in this PokeAPI/pokeapi#488 PR.
This deploy job will be mostly invoked by API calls done by
pokeapi.coandapi-data. This job will deploy to the productive Firebase (pokeapi.co) if this repo gets pushed or if themasterbranch of eitherpokeapi.coorapi-datais pushed. When deploying it will always usepokeapi.coandapi-data's artifacts based on theirmasterbranches.When the branch
stagingof eitherpokeapi.coorapi-datawill be pushed then the job will deploy the artifacts based on their aforementionedstagingbranches to a new Firebase staging environment (https://pokeapi-test-b6137.firebaseapp.com) (I will give access to @phalt, @tdmalone, @cmmartti to this Firebase project). It would be also nice if @phalt could create the subdomainstaging.pokeapi.coand link it to the Firebase project. To do so we should create the new domain, add aTXTrecord type withhostequal to pokeapi.co andvalueequal to google-site-verification=gV4NnTbUxNds2dIATNVlEyHCfWBgOjte2cNuAdlIVA0. Then probably we need to add the Firebase nameservers to the Namecheap domain config. I will also need to change some strings here and there in the PR I just opened.This PR is linked to the following PRs:
This PR should be the first to be merged among them.