feat: [PPT-2454] sanitize attributes - #313
Merged
stakach merged 13 commits intoMay 22, 2026
Merged
Conversation
github-actions
Bot
added
type: enhancement
github-actions
Bot
added
type: enhancement
github-actions
Bot
added
type: enhancement
github-actions
Bot
added
type: enhancement
github-actions
Bot
added
type: enhancement
chillfox
marked this pull request as ready for review
May 1, 2026 02:40
naqvis
reviewed
May 2, 2026
naqvis
left a comment
naqvis
left a comment
Contributor
There was a problem hiding this comment.
I see we have introduced new attribute tag, but I don't see where is that handled and how that's going to handle. When we have introduced a tag, why do we need a separate before save hook? might be response to questions i have asked is buried under the linter noise.
Contributor
Author
|
@naqvis The attribute tag is in spider-gazelle/active-model@cfa6cba. The |
github-actions
Bot
added
type: enhancement
Contributor
Author
|
I guess we should add |
chillfox
marked this pull request as draft
May 19, 2026 07:03
github-actions
Bot
added
type: enhancement
github-actions
Bot
added
type: enhancement
chillfox
marked this pull request as ready for review
May 21, 2026 23:28
chillfox
requested review from
naqvis and
stakach
and removed request for
stakach
May 21, 2026 23:28
naqvis
requested changes
May 21, 2026
naqvis
left a comment
naqvis
left a comment
Contributor
There was a problem hiding this comment.
Can we make linter happy?
stakach
deleted the
PPT-2454-vulnerability-report-improper-sanitisation-of-inputs
branch
May 22, 2026 00:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and fix ameba issues.