Skip to content

chore(authority): add default_app to config - #197

Merged
stakach merged 2 commits into
masterfrom
chore/default-app
Mar 1, 2023
Merged

chore(authority): add default_app to config#197
stakach merged 2 commits into
masterfrom
chore/default-app

Conversation

@viv-4

@viv-4 viv-4 commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

Description of the change

Adds default_app with default of /backoffice/ when creating a domain

Benefits

Avoids having to manually set it.
Kubernetes ingress overrides which currently handle this will be removed.

Applicable issues

https://acaprojects.atlassian.net/browse/PPT-108

@viv-4 viv-4 self-assigned this Mar 1, 2023
@github-actions github-actions Bot added the type: chore Tooling; no production code change or library break fix label Mar 1, 2023
@viv-4
viv-4 requested a review from stakach March 1, 2023 01:27
@github-actions github-actions Bot added type: chore Tooling; no production code change or library break fix and removed type: chore Tooling; no production code change or library break fix labels Mar 1, 2023

@stakach stakach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach
stakach merged commit 35082dc into master Mar 1, 2023
@stakach
stakach deleted the chore/default-app branch March 1, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore Tooling; no production code change or library break fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants