Skip to content

feat(entities): add hierarchy zones - #24

Merged
caspiano merged 2 commits into
masterfrom
feat/source-requirements
Apr 28, 2021
Merged

feat(entities): add hierarchy zones#24
caspiano merged 2 commits into
masterfrom
feat/source-requirements

Conversation

@caspiano

@caspiano caspiano commented Feb 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Adds placeholder Model::Zone for each hierarchical zone tag. i.e. building, org, level, area
  • Removes Test prefix from development entities

@caspiano
caspiano requested review from a team, dukenguyenxyz and kimburgess and removed request for a team February 22, 2021 03:45
@kimburgess

kimburgess commented Feb 22, 2021

Copy link
Copy Markdown
Contributor

Is it worth popping in a building and level tagged zone here too to provide the full base hierarchy?

@caspiano

caspiano commented Feb 22, 2021

Copy link
Copy Markdown
Contributor Author

Good idea @kimburgess

@caspiano caspiano added the type: enhancement new feature or request label Mar 25, 2021
@kimburgess kimburgess mentioned this pull request Apr 19, 2021
Closed
@caspiano
caspiano force-pushed the feat/source-requirements branch from 8c9e4be to 94231e6 Compare April 27, 2021 06:02
@caspiano
caspiano requested a review from dukenguyenxyz April 27, 2021 06:05
@caspiano
caspiano force-pushed the feat/source-requirements branch from 94231e6 to fdcec32 Compare April 27, 2021 06:13
@caspiano caspiano changed the title feat(entities): add zone with a top level hierarchy feat(entities): add hierarchy zones Apr 27, 2021
kimburgess
kimburgess reviewed Apr 27, 2021
View reviewed changes
Comment thread src/tasks/entities.cr
Comment thread src/tasks/entities.cr
Comment thread src/tasks/entities.cr Outdated
@caspiano
caspiano force-pushed the feat/source-requirements branch from fdcec32 to d9692fb Compare April 28, 2021 01:23
@caspiano
caspiano merged commit 4b93f95 into master Apr 28, 2021
@caspiano
caspiano deleted the feat/source-requirements branch April 28, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dukenguyenxyz dukenguyenxyz Awaiting requested review from dukenguyenxyz
1 more reviewer
@kimburgess kimburgess kimburgess left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@caspiano caspiano

Labels

priority: high type: enhancement new feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caspiano @kimburgess @dukenguyenxyz