feat(visitor_mailer): add the check-in code to change notifications (PPT-2375) - #620
Open
chillfox wants to merge 1 commit into
Open
feat(visitor_mailer): add the check-in code to change notifications (PPT-2375)#620chillfox wants to merge 1 commit into
chillfox wants to merge 1 commit into
Conversation
This was referenced Jul 30, 2026
Merged
chillfox
marked this pull request as ready for review
August 2, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of scenario 5 of PPT-2375. The duplicate
visitor_invited.eventQA reported is fixed by PlaceOS/staff-api#382, which stops the staff API re-announcing visitors when a meeting changes room. This is what remains: the change notification now has to carry the visitor's check-in details, because nothing else will.Why
The kiosk link issued with a visitor's original invitation embeds a token scoped to the room the meeting was in. Move the meeting and that link is stale — and no fresh invitation is sent, by design. The
booking_changedandevent_changedtemplates therefore getguest_jwt,kiosk_urland the same inlineqr.pngattachment an invitation carries, built exactly the way the invitation builds them.For a calendar event the QR names the room the meeting moved to; for a booking it names the asset, mirroring the invite flow's choice of
resource_id/system_id.disable_qr_code: trueleaves the attachment off, as it does for invitations. Until a template references the new fields they are simply unused, though an unreferenced attachment may still surface in some mail clients — worth updating the templates alongside this.Testing
5 specs: the fields and attachment on both changed templates, the QR contents pointing at the new room,
disable_qr_code,template_fieldsexposing the fields to the template editor, and a guard that the host force-added to the attendee list by the staff API still doesn't get a visitor invitation../harness report --basic-render --verbose --tests=1 drivers/place/visitor_mailer_spec.crpasses;crystal tool formatandamebaclean.Earlier revisions of this branch also held and suppressed re-invites in the driver, as insurance against a staff API that re-announced everyone on a room move. staff-api#382 merged first, so that machinery would now only ever fire on the one visitor genuinely added during a move — dropping their invitation instead of sending it. It has been removed rather than carried.