Conversation
w-le
self-requested a review
February 26, 2025 05:56
w-le
requested changes
Feb 27, 2025
w-le
left a comment
w-le
left a comment
Contributor
There was a problem hiding this comment.
Thanks @naqvis , looks great!
One change we will need though is that the device_id will not be a static string in this Drivers Settings (such that an instance of this driver will only over control 1 device), but a String Parameter of all commands this Driver exposes, such that the caller (e.g. a Logic driver or frontend app) can request this Service Driver to command any of hundreds of physical devices that the xAPI session allows.
Are you able to make that change?
w-le
approved these changes
Feb 27, 2025
w-le
left a comment
w-le
left a comment
Contributor
There was a problem hiding this comment.
device-id change looks good, thanks. PR approved and I'll test e2e then comment or merge.
In the mean time, you can continue to work on Phase 2 of PPT-1818, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.