Add missing fields to the user model - #302
Merged
Merged
Conversation
w-le
approved these changes
Apr 13, 2022
Contributor
There was a problem hiding this comment.
the fields aligns, apart from privacy which isn't in the floorsense docs (maybe it's new?)
https://apiguide.smartalock.com/#2b73222c-a86e-4cc2-8a12-d8d307adf3b1
Example Response from floorsense api
{
"result": true,
"type": "response",
"info": {
"email": "simon@amixcapital.com",
"uid": "31344311",
"usertype": "user",
"pin": "8721",
"name": "Simon Hope",
"lastlogin": 1582692563,
"expiry": 0,
"extid": "9876543210987654321",
"reslimit": 0,
"uidtoken": "694433b85d6c7b2dd2c37c75a9c9a401",
"desc": "#firstaid"
}
}
Author
|
Thanks @w-le , if we keep the privacy one there, would it break anything? |
Contributor
|
yep I don't think it will break anything so I've approved the PR. We'll let @stakach review as well since he is much more familiar with this driver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some missing fields to the user model in floorsense.