Skip to content

Disabled buttons#3203

Open
IntegratedQuantum wants to merge 4 commits into
PixelGuys:masterfrom
IntegratedQuantum:disabled_buttons
Open

Disabled buttons#3203
IntegratedQuantum wants to merge 4 commits into
PixelGuys:masterfrom
IntegratedQuantum:disabled_buttons

Conversation

@IntegratedQuantum

Copy link
Copy Markdown
Member

With a reference use-case (showing the social settings that cannot be changed when in the world, previously they were hidden, now they are shown as disabled):
Screenshot at 2026-06-10 08-51-22

To achieve this I made a small change to the button interface to allow for optional arguments

replaces #2008

fixes #2556

@tillpp

tillpp commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Please rework the design of the grayed out button. (and honestly it's terrible in its current state)

@OneAvargeCoder193

Copy link
Copy Markdown
Contributor

I think it would make more sense if disabled buttons always drew the pressed texture

@OneAvargeCoder193

Copy link
Copy Markdown
Contributor
image

@Wunka

Wunka commented Jun 10, 2026

Copy link
Copy Markdown
Contributor
image

I don't like this. This looks more like a bug then a disabled button feature

@Argmaster

Copy link
Copy Markdown
Collaborator

Full gray scale is the answer you are looking for.

@Crepestrom

Copy link
Copy Markdown
Contributor

if you look at my recolored slots pr you can use that to make darker slots

@IntegratedQuantum

Copy link
Copy Markdown
Member Author

@careeoki can you help me with the texture once you are back from your trip?

@careeoki

Copy link
Copy Markdown
Contributor

@careeoki can you help me with the texture once you are back from your trip?

I was home monday so I can help right now: IntegratedQuantum#1

@IntegratedQuantum

Copy link
Copy Markdown
Member Author

I think a good change to make it feel even more disabled would be to make the text a bit darker:

Sadly that is not possible currently. I could make it transparent, but it looks kind of odd:
Screenshot at 2026-06-11 21-41-43

IntegratedQuantum added a commit that referenced this pull request Jun 13, 2026
This makes color state spill less (→no draw.setColor(0xffffffff)
everywhere to restore incorrect state) and allows GUI components to
color their children.

Demo (VerticalList is red, HorizontalList is green):
<img width="1280" height="745" alt="Screenshot at 2026-06-12 20-29-36"
src="https://github.com/user-attachments/assets/83e8049f-5768-46d0-a442-19c5df2bc8a6"
/>

This is required for
#3203 (comment) to
make the text/icon darker
@IntegratedQuantum

Copy link
Copy Markdown
Member Author

Alright here we go:
Screenshot at 2026-06-13 10-38-20

@IntegratedQuantum

Copy link
Copy Markdown
Member Author

And it works on icons too
Screenshot at 2026-06-13 10-41-20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Social options while in-game could use clarification

7 participants