Disabled buttons#3203
Open
IntegratedQuantum wants to merge 4 commits into
Open
Conversation
Contributor
|
Please rework the design of the grayed out button. (and honestly it's terrible in its current state) |
Contributor
|
I think it would make more sense if disabled buttons always drew the pressed texture |
Contributor
Contributor
Collaborator
|
Full gray scale is the answer you are looking for. |
Contributor
|
if you look at my recolored slots pr you can use that to make darker slots |
Member
Author
|
@careeoki can you help me with the texture once you are back from your trip? |
Contributor
I was home monday so I can help right now: IntegratedQuantum#1 |
Member
Author
IntegratedQuantum
added a commit
that referenced
this pull request
Jun 13, 2026
This makes color state spill less (→no draw.setColor(0xffffffff) everywhere to restore incorrect state) and allows GUI components to color their children. Demo (VerticalList is red, HorizontalList is green): <img width="1280" height="745" alt="Screenshot at 2026-06-12 20-29-36" src="https://github.com/user-attachments/assets/83e8049f-5768-46d0-a442-19c5df2bc8a6" /> This is required for #3203 (comment) to make the text/icon darker
addd322 to
f69428a
Compare
Member
Author
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




With a reference use-case (showing the social settings that cannot be changed when in the world, previously they were hidden, now they are shown as disabled):

To achieve this I made a small change to the button interface to allow for optional arguments
replaces #2008
fixes #2556