Show the actual error message in the error popup#2263
Open
thecreare wants to merge 10 commits into
Open
Conversation
Contributor
|
This PR seems to been missed... |
Contributor
Author
|
Resolved the conflicts and tested it |
Contributor
|
Nice, I moved into prs to review. sorry again that this was missed before |
Wunka
suggested changes
May 11, 2026
Co-authored-by: Wunka <56411012+Wunka@users.noreply.github.com>
Wunka
approved these changes
May 12, 2026
IntegratedQuantum
requested changes
May 15, 2026
| const Button = @import("../components/Button.zig"); | ||
|
|
||
| var overflowErrorCount: u32 = 0; | ||
| var errorText: ?[]const u8 = null; |
Member
There was a problem hiding this comment.
make your life easy: Allocators will ignore zero-length allocations.
Suggested change
| var errorText: ?[]const u8 = null; | |
| var errorText: []const u8 = ""; |
| } | ||
|
|
||
| if (level == .err and !openingErrorWindow and !settings.launchConfig.headlessServer) { | ||
| openingErrorWindow = true; |
Member
There was a problem hiding this comment.
This exists to prevent infinite recursion when there is an error while trying to open the error window.
(this e.g. happens when there is an error before the gui is initialized)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
raiseErrorfunction to theerror_promptwindow thatFixes #1554