Skip to content

add DropdownList#2065

Closed
Wunka wants to merge 4 commits into
PixelGuys:masterfrom
Wunka:dropdown
Closed

add DropdownList#2065
Wunka wants to merge 4 commits into
PixelGuys:masterfrom
Wunka:dropdown

Conversation

@Wunka

@Wunka Wunka commented Oct 19, 2025

Copy link
Copy Markdown
Contributor

Depends on #2053
Closes #1920

Currently renders the selected item or the selectable list.

@OneAvargeCoder193

Copy link
Copy Markdown
Contributor

I would recommend adding an example use case to this pr, maybe where the world gamemode is chosen in the world create menu.

@BoySanic BoySanic moved this to WIP/not ready for review in PRs to review Nov 3, 2025
IntegratedQuantum pushed a commit that referenced this pull request Nov 5, 2025
While implement culling in VerticalList.render #2024 the culling was
only tested on the chat from what I know.

While making a example for #2065 I noticed a bug while showing the list.
Problem was `shiftedPos` is relative to the parent component, different
than all other variables used in the if.
I did not create an issue because I knew the problematic code and was
able to make a quick fix. I can also make an issue if wanted.
Argmaster pushed a commit to Argmaster/Cubyz that referenced this pull request Nov 6, 2025
While implement culling in VerticalList.render PixelGuys#2024 the culling was
only tested on the chat from what I know.

While making a example for PixelGuys#2065 I noticed a bug while showing the list.
Problem was `shiftedPos` is relative to the parent component, different
than all other variables used in the if.
I did not create an issue because I knew the problematic code and was
able to make a quick fix. I can also make an issue if wanted.
@Wunka

Wunka commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

Example is now fully working. I did not want to work on this due to this weird hover bug.
But this solved itself as it seems. Here is the branch.
I think a lot can be done different based on what its supposed to do.
Currently the dropdownlist only changed between rendering the selected item and the list. But maybe we want the list to be displayed atop of everything else? I would have to look into how I could do that.

@IntegratedQuantum

Copy link
Copy Markdown
Member

I took a look at this today and I think this would be better if it used its own selection and rendering logic.

The current implementation with the selectable list doesn't even look remotely like a dropdown list and I think it would be best if the dropdown would handle its own rendering and selection logic.
Also future logic (e.g. other dropdown often include a hidden search option) is incompatible with a selectable list.

@IntegratedQuantum

Copy link
Copy Markdown
Member

But maybe we want the list to be displayed atop of everything else?

Yes, and with a nice outline and all that.

@Wunka

Wunka commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

I took a look at this today and I think this would be better if it used its own selection and rendering logic.

The current implementation with the selectable list doesn't even look remotely like a dropdown list and I think it would be best if the dropdown would handle its own rendering and selection logic. Also future logic (e.g. other dropdown often include a hidden search option) is incompatible with a selectable list.

Before I start again I will make a few mock ups for the design and will comment them on the dropdown issue.

I will also close this PR for now as I don't know if I will continue with this PR or start from scratch

@Wunka Wunka closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add a drop down menu to ui

5 participants