add DropdownList#2065
Conversation
|
I would recommend adding an example use case to this pr, maybe where the world gamemode is chosen in the world create menu. |
While implement culling in VerticalList.render #2024 the culling was only tested on the chat from what I know. While making a example for #2065 I noticed a bug while showing the list. Problem was `shiftedPos` is relative to the parent component, different than all other variables used in the if. I did not create an issue because I knew the problematic code and was able to make a quick fix. I can also make an issue if wanted.
While implement culling in VerticalList.render PixelGuys#2024 the culling was only tested on the chat from what I know. While making a example for PixelGuys#2065 I noticed a bug while showing the list. Problem was `shiftedPos` is relative to the parent component, different than all other variables used in the if. I did not create an issue because I knew the problematic code and was able to make a quick fix. I can also make an issue if wanted.
|
Example is now fully working. I did not want to work on this due to this weird hover bug. |
|
I took a look at this today and I think this would be better if it used its own selection and rendering logic. The current implementation with the selectable list doesn't even look remotely like a dropdown list and I think it would be best if the dropdown would handle its own rendering and selection logic. |
Yes, and with a nice outline and all that. |
Before I start again I will make a few mock ups for the design and will comment them on the dropdown issue. I will also close this PR for now as I don't know if I will continue with this PR or start from scratch |
Depends on #2053
Closes #1920
Currently renders the selected item or the selectable list.