feat(manifest): add stream EventEmitter methods to API gate#967
Merged
Conversation
Adds stream.on/once/off/emit/removeListener/removeAllListeners and the rest of the EventEmitter surface so axios (and packages extending stream.Transform) get past the #463 unimplemented-API gate at compile time. Verified: axios 1.7.7 now compiles + runs (separate runtime gap surfaces as axios.get returning undefined - tracked separately).
2 tasks
proggeramlug
added a commit
that referenced
this pull request
May 18, 2026
PRs #966, #967, #982, #984 added entries to perry-api-manifest::API_MANIFEST (stream EventEmitter instance methods, stream.prototype, lodash inRange/max/maxBy/mean/meanBy/min/minBy/random/sum/sumBy/tail) without rerunning ./scripts/regen_api_docs.sh. Drift has been blocking the api-docs-drift gate on every subsequent PR; unblocking the next batch. Coverage moves from 870 → 898 entries across 71 modules. Mechanical regen, no manifest edits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
stream.on/once/off/emit/removeListener/removeAllListeners(plusaddListener/prependListener/prependOnceListener/listenerCount/listeners/rawListeners/eventNames/setMaxListeners/getMaxListeners) to the Perry API manifest incrates/perry-api-manifest/src/entries.rs. These are EventEmitter methods that everyReadable/Writable/Duplex/Transform/PassThroughinstance exposes — Perry rejected them at the #463 unimplemented-API gate even though the runtime closures were already wired throughcrates/perry-runtime/src/node_stream.rs.Repro before
After
axios 1.7.7 now compiles + runs past the gate.
axios.getstill resolves toundefinedat runtime — that's a separate runtime gap (likely default-export getter on the compiled CJS bundle), not blocked by this PR.Test plan
test-files/test_stream_on.ts(Readableinstance +.on('data')/.on('end')wiring) compiles. Runtime event delivery is a separate issue tracked elsewhere.