fix(codegen): lodash _.add undefined — CJS IIFE .call(this) + IndexUpdate codegen#960
Closed
proggeramlug wants to merge 1 commit into
Closed
fix(codegen): lodash _.add undefined — CJS IIFE .call(this) + IndexUpdate codegen#960proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
`import _ from "lodash"; _.add(1, 2)` resolved `_` to undefined under
`perry.compilePackages: ["lodash"]`. Two distinct bugs combined:
1. Inline `;(function() { ... }.call(this))` IIFE bodies never executed
— `Closure.call` fell through generic method dispatch — so the CJS
wrap's `module.exports = _` write was silently dropped. Fix:
rewrite `<FnExpr|ArrowExpr>.call(thisArg, ...args)` to a direct
call dropping the thisArg when the closure doesn't capture `this`.
2. `Expr::IndexUpdate` (`++arr[i]` / `obj[key]++`) bailed at codegen
with `not yet supported`, stubbing lodash entirely. Fix: lower
read/modify/write through `js_dyn_index_get` (extended for
string-key dispatch) and a new `js_dyn_index_set` runtime helper
that routes by gc_type.
Real lodash advances past the `_.add` undefined symptom; the next
runtime gap (`Function('return this')()` not callable, bare `global`
not truthy) is tracked separately.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import _ from "lodash"; _.add(1, 2)resolved_to undefined underperry.compilePackages: ["lodash"]. Two distinct bugs combined:Inline
;(function() { ... }.call(this))IIFE bodies never executed —Closure.callfell through generic method dispatch — so the CJS wrap'smodule.exports = _write was silently dropped. Fix: rewrite<FnExpr|ArrowExpr>.call(thisArg, ...args)to a direct call dropping the thisArg when the closure doesn't capturethis.IndexUpdatecodegen related fix for lodash's exports table.Test plan
_.add(1, 2)now produces correct output