test(compile): #678 add Ink linker smoke#942
Merged
proggeramlug merged 1 commit intoMay 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a real Ink compile/link fixture that locks issue #678's V8-fallback linker contract. The current Ink repro now links; executing the binary reaches a separate
hasOwnPropertyruntime interop gap, so this fixture intentionally stops at link-time proof.Changes
tests/release/packages/ink-link-smokepinned toreact@18.3.1andink@5.2.1.perry_fn/perry_closureInk symbols.tests/release/packages/README.md.Related issue
Closes #678
Test plan
cargo build --releasecleancargo test --workspace --exclude perry-ui-ios --exclude perry-ui-tvos --exclude perry-ui-watchos --exclude perry-ui-gtk4 --exclude perry-ui-android --exclude perry-ui-windowspassestests/release/packages/docs/src/-p perry-ui-<backend>locally on that platformAdditional validation:
PERRY_BIN="$PWD/target/release/perry" tests/release/packages/_harness.sh --filter ink-link-smoketarget/release/perry compile test-files/test_issue_678_v8_fallback.ts -o ...+ Node difftarget/release/perry compile test-files/test_issue_678_reexport_default.ts -o ...+ Node diffcargo fmt --all -- --checkgit diff --checkScreenshots / output
Checklist
feat:/fix:/docs:/chore:prefix convention used in the log