[codex] Implement node TLS compatibility surface#3786
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
e4cf95b to
c8bfc16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkServerIdentity,createSecureContext, andSecureContext.tls.createServer,tls.Serverlifecycle/event handling, context/ticket-key helpers, and TLSSocket-shaped client/server certificate, session, cipher, protocol, and keying-material introspection.This stays rustls-only and intentionally leaves deprecated
tls.createSecurePairout of scope.Issue Resolution
Closes #3196
Closes #3197
Closes #3198
Closes #3199
Closes #3200
Validation
cargo fmt --checkcargo build --release -p perry -p perry-stdlib -p perry-runtimetarget/release/perry test-files/test_issue_3196_3198_tls_helpers.ts -o /tmp/perry_tls_helpers && /tmp/perry_tls_helperstarget/release/perry test-files/test_issue_3199_3200_tls_server_tlssocket.ts -o /tmp/perry_tls_server_tlssocket && /tmp/perry_tls_server_tlssocketcargo test --release -p perry-stdlib --libcargo test --release -p perry-ext-netcargo test --release -p perry-ext-http-servercargo test -p perry-codegen --test manifest_consistency -- --nocaptureNotes:
cargo test --release -p perry-runtime --libreported 846/849 passing; the twonode_streamfailures reproduce on a clean detachedHEADworktree, and the GC telemetry timing failure passed when rerun alone../run_parity_tests.sh --filter test_parity_tlsbuilt Perry successfully but local Node v22.22.1 skipped before comparison withERR_NO_TYPESCRIPTfor--experimental-strip-types; a manual stdin Node comparison matched except for deprecated/out-of-scopetls.createSecurePair.