[#3598] Add FormData constructor and mutator parity#3642
Merged
proggeramlug merged 8 commits intoJun 1, 2026
Conversation
365d69d to
5973903
Compare
86ccf3e to
0fc6cbd
Compare
added 3 commits
June 1, 2026 07:52
…-methods # Conflicts: # crates/perry-runtime/src/object/global_this.rs # docs/api/perry.d.ts # docs/src/api/reference.md # scripts/check_file_size.sh
Resolve conflicts in global_this.rs (FormData proto-method arms vs. WebSocket/Crypto/CryptoKey arms from main; tables relocated to global_this_tables.rs picked up main's Storage/WebSocket/WebAssembly additions) and regenerate API docs (2496 entries).
Re-resolve global_this.rs after main absorbed the Navigator work: keep the relocated tables (global_this_tables.rs) and fold in main's Navigator constructor + spec_length(0); merge the prototype-constructor install so both the web-fetch ctors (FormData/Headers/Request/Response/Blob/File) and Navigator/TextEncoder|DecoderStream get their .constructor. Regenerate API docs (2499 entries).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3598
Summary
new FormData()lowering plus native FormData registry allocationappend,set,delete,has,get,getAll,entries,keys,values, andforEachthrough typed and any-typed fetch handle dispatchVerification
cargo fmt --checknode --experimental-strip-types test-parity/node-suite/fetch/form-data/constructor-mutators.tscargo check -p perry-stdlib -p perry-runtime -p perry-codegen -p perry-hircargo build -p perry -p perry-runtime -p perry-stdlibPERRY_ALLOW_UNIMPLEMENTED=1 ./target/debug/perry test-parity/node-suite/fetch/form-data/constructor-mutators.ts -o /tmp/perry_formdata_constructor_mutators && /tmp/perry_formdata_constructor_mutatorsmatched the Node baseline; the fetch sidecar auto-optimize build was bounded/stopped after dependency build contention and Perry fell back to prebuilt libs before linking/running the fixture../run_parity_tests.sh --suite node-suite --module fetch, stopped while it was sitting in release-build contention without useful fixture output.Remaining Fetch/FormData Work
globalThis.fetchvalue exposure; that remains separate from draft PR fix(fetch): expose globalThis fetch value #3632.