[codex] node:v8 lifecycle helper surfaces#3622
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3139
Closes #3141
node:v8native module namespace for Perry-backed lifecycle helpers onlyv8.promiseHooks.onInit/onBefore/onAfter/onSettled/createHookon Perry Promise allocation, callback execution, and settlement pathsv8.startupSnapshotnormal-runtime helper state:isBuildingSnapshot()returns0, registration helpers throwERR_NOT_BUILDING_SNAPSHOTValidation
command -v curl && command -v python3 && bash ~/.codex/skills/deepwiki/scripts/run.sh --repo PerryTS/perry --question ... --output /tmp/perry-node-v8-lifecycle-deepwiki.md --timeout 1800- passedcargo fmt --check- passedcargo check -p perry-runtime- passedscripts/regen_api_docs.sh- passedtarget/release/perry test-files/test_parity_v8_lifecycle.ts -o /tmp/perry_v8_lifecycle && /tmp/perry_v8_lifecycle- passed; output matches the equivalent Node plain-JS probe./run_parity_tests.sh --filter test_parity_v8_lifecycle- local environment skipped the fixture because/usr/bin/nodev22.22.1 is built without TypeScript stripping (ERR_NO_TYPESCRIPTfor any.tsfile)cargo test -p perry-codegen --test manifest_consistency- passed (4 tests)cargo test -p perry-api-manifest- passed (12 tests + doctests)cargo test -p perry-runtime- attempted; the parallel full suite reportedgc::tests::barrier::test_minor_gc_promotes_after_two_survivalsonce and then hung in long GC tests. Rerancargo test -p perry-runtime gc::tests::barrier::test_minor_gc_promotes_after_two_survivals -- --nocaptureand it passed.