fix(path): align lexical and win32 edge cases#3501
Open
andrewtdiz wants to merge 1 commit into
Open
Conversation
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2986
Closes #2994
Closes #2995
Closes #2997
Closes #2998
Closes #2999
Summary
path.resolve()lexical for existing symlinked paths instead of canonicalizing through the filesystembasename()while preserving explicitundefinedas an omitted suffixpath.relative()/path.win32.relative()arguments and match win32 drive-relative resolve/relative behavior..basenames as extensionless inextname()andparse()Verification
PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module path-> 90 pass, 0 fail, 0 compile fail (test-parity/reports/parity_report_20260531_012533.json)RUSTC_WRAPPER= cargo check -p perry-runtime -p perry-codegen -p perry-hir -p perry-api-manifest -p perry-> passed with existing warningscargo fmt --all -- --check-> passed./scripts/check_file_size.sh-> passedjq empty test-parity/known_failures.json-> passedgit diff --check && git diff --cached --check-> passed