Skip to content

fix(dgram): expose socket shape stub#3391

Merged
proggeramlug merged 8 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-dgram-shape-stub
May 31, 2026
Merged

fix(dgram): expose socket shape stub#3391
proggeramlug merged 8 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-dgram-shape-stub

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

  • Add runtime-only node:dgram namespace/socket shape stubs for createSocket, Socket, and socket method fields.
  • Register dgram in the API manifest/native dispatch and keep socket method value reads callable.
  • Remove the now-passing test_parity_dgram known-failure entry and regenerate API docs.

Verification

  • cargo check -p perry-runtime -p perry-hir -p perry-codegen -p perry-api-manifest
  • cargo test -p perry-codegen --test manifest_consistency
  • ./run_parity_tests.sh --filter test_parity_dgram
  • ./scripts/regen_api_docs.sh
  • cargo fmt --all -- --check
  • ./scripts/check_file_size.sh
  • jq empty test-parity/known_failures.json
  • git diff --check

andrewtdiz and others added 2 commits May 30, 2026 08:52
# Conflicts:
#	crates/perry-codegen/src/lower_call/native_table/node_core.rs
#	crates/perry-runtime/src/object/native_module.rs
#	docs/api/perry.d.ts
#	docs/src/api/reference.md
@andrewtdiz
Copy link
Copy Markdown
Contributor Author

Merged current origin/main into this branch and resolved the API manifest/doc conflicts by keeping the mainline module.SourceMap entry plus the dgram socket shape stubs. Regenerated docs now report 1823 entries across 90 modules.\n\nLocal verification:\n- cargo fmt --all -- --check\n- git diff --check && git diff --cached --check\n- ./scripts/check_file_size.sh\n- ./scripts/regen_api_docs.sh equivalent using the freshly built release binary

Ralph Küpper and others added 2 commits May 30, 2026 19:43
@andrewtdiz
Copy link
Copy Markdown
Contributor Author

Updated this branch after the latest mainline merge.\n\n- The branch was already rebased/merged up to origin/main on the fork ref I fetched.\n- Added the shared cargo-test disk-pressure mitigation to the CI workflow.\n- Local checks passed: cargo fmt --all -- --check, git diff --check, scripts/check_file_size.sh, and workflow YAML parsing.

@andrewtdiz
Copy link
Copy Markdown
Contributor Author

Fixed the cargo-test failure from the latest run.

The failing test was stable_hash::tests::expr_variant_stable_hash_tags_are_unique, caused by duplicate Expr stable-hash tag 12043 for RegExpEscape and StringRaw. I applied the same RegExpEscape stable-hash tag fix used on #3414.

Local checks passed: CARGO_TARGET_DIR=/root/perry/target cargo test -p perry-hir stable_hash::tests::expr_variant_stable_hash_tags_are_unique, cargo fmt --all -- --check, and git diff --check HEAD~1..HEAD.

Ralph Küpper and others added 2 commits May 30, 2026 20:42
@andrewtdiz
Copy link
Copy Markdown
Contributor Author

Fixed the cargo-test failure by merging current origin/main, which now carries the ReflectIsExtensible stable-hash tag correction for the RegExpEscape collision.

Local checks passed: CARGO_TARGET_DIR=/root/perry/target cargo test -p perry-hir stable_hash::tests::expr_variant_stable_hash_tags_are_unique and git diff --check.

# Conflicts:
#	crates/perry-hir/src/lower/expr_member.rs
#	docs/api/perry.d.ts
#	docs/src/api/reference.md
@proggeramlug proggeramlug merged commit ded97b2 into PerryTS:main May 31, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants