feat: implement lrclib integration for lyrics#108
Merged
Conversation
Signed-off-by: toddynnn <86982643+ToddyTheNoobDud@users.noreply.github.com>
Signed-off-by: toddynnn <86982643+ToddyTheNoobDud@users.noreply.github.com>
Signed-off-by: toddynnn <86982643+ToddyTheNoobDud@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This commit adds lrclib support for lyrics parsing/fetching, by default enabled
This commit also improves the fallback sources with a tiny performance boost and better fallback per source
Why
This improves Nodelink's lyrics system, because lrclib has a vast amount of usable lyrics with synced or non-synced ones; while also beign very performant and fast for fetching and does not require any additional configuration
Checkmarks
Additional information