qrep: if the last sync is nil, check the table if there are new rows. - #1667
Merged
iskakaushik merged 1 commit intoMay 7, 2024
Conversation
this bug can prevent tables which are empty to be synced once they get data.
serprex
approved these changes
May 3, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this bug can prevent tables which are empty to be synced once they get data.
in general one has to be very careful here with nil pointer exceptions, I tried to navigate them to the best of my ability but this code path makes lots of assumptions about the state of the world.