Fix Breakdown of Crit Damage when using Dance with Death#9012
Merged
Conversation
When using the Dance with Death keystone to have Critical Damage be lucky, it was not correctly showing the correct formula for Crit Damage Crit Damage is handled in pass 1 so output.DamageRolls was being overwritten to 0 after pass 2 was done for non-crit damage calcs So now we have a new variable just for Crit Damage rolls that cannot be overwritten and we use that for the breakdown
Wires77
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9011
Description of the problem being solved:
When using the Dance with Death keystone to have Critical Damage be lucky, it was not correctly showing the correct formula for Crit Damage
Crit Damage is handled in pass 1 so output.DamageRolls was being overwritten to 0 after pass 2 was done for non-crit damage calcs
So now we have a new variable just for Crit Damage rolls that cannot be overwritten and we use that for the breakdown
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/hGvQM_hqvpJE
Before screenshot:
After screenshot: