Fix importing characters with names that contain foreign letters#8935
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Aug 11, 2025
Merged
Conversation
|
I can attest a successful test of this patch: I ran into the same import problem with my character whose name contains a single single |
2 tasks
Contributor
|
Tested OK with: Egniel#3548 - РикиМортьевич |
LocalIdentity
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8933
Ideally, we would want to display the non-ASCII chars properly. It seems to be a problem of fonts, which I'm uncertain how to fix now. This would at least allow characters with name containing non-ASCII characters to be imported to PoB.
Description of the problem being solved:
When importing data from POE with a character name containing non-ASCII characters, we will get a 400 error. This is due to the utf-8 encoding of those characters not being compatible with URL encoding.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A
Before screenshot:
After screenshot: