Fix Spark maximum hits being calculated incorrectly #8833
Merged
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom Jul 14, 2025
jeremykvlim:dev
Merged
Fix Spark maximum hits being calculated incorrectly #8833LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom jeremykvlim:dev
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
jeremykvlim:dev
Conversation
LocalIdentity
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7690.
Description of the problem being solved:
Spark's maximum number of hits is currently being calculated as
floor(duration / 0.66). It should be1 + floor(duration / 0.66), as the first hit occurs at 0.00s before the 0.66s lockout intervals begin.Link to a build that showcases this PR:
https://pobb.in/6-1VzBKNlMw0
This build has 4.059s Spark duration. The current calculated maximum hits is
floor(4.059 / 0.66) = 6. This is incorrect. Spark can hit 7 times at the following timings: 0.00s, 0.66s, 1.32s, 1.98s, 2.64s, 3.30s, 3.96s.Before screenshot:
After screenshot: