Fix gems being added to skill groups when sorting dropdown#8802
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Jul 8, 2025
Merged
Conversation
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 29, 2025
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Aug 29, 2025
Copy from PathOfBuildingCommunity/PathOfBuilding#8802 Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
…ldingCommunity#1221) Copy from PathOfBuildingCommunity/PathOfBuilding#8802 Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue mentioned on discord
Description of the problem being solved:
When generating skill gem selection dropdown cache the displayGemList was not correctly reset to the previous state causing temporarily added gems to remain visible in tooltip. This issue is rather complex as essentially each calculation instance modifes the global state of the displayGemList. While the solution proposed in this PR fixes the issue currently it is rather fragile and could break in the future.