Add rudimentary trigger tests#6574
Merged
LocalIdentity merged 8 commits intoPathOfBuildingCommunity:devfrom Dec 5, 2023
Merged
Add rudimentary trigger tests#6574LocalIdentity merged 8 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 8 commits intoPathOfBuildingCommunity:devfrom
Conversation
Fixes order mattering in tests. gemData is never refreshed after program start.
This reverts commit ac203b7.
LocalIdentity
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds rudimentary tests for trigger skills.
ac203b7 was caused by:
PathOfBuilding/src/Classes/SkillsTab.lua
Line 1081 in bc2f756
gemData granted effects are set on program startup and never refreshed otherwise. This means that anything set in there will persist through build xml loads.
Tool reference for debugging tests running inside of a container with emmylua. (the emmy_core.so that comes with the extension doesn't work. Glibc mismatch issues.)