Add option to only compare stats for same jewel types.#6314
Open
michelrtm wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Add option to only compare stats for same jewel types.#6314michelrtm wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
michelrtm wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Contributor
Author
|
I realized I forgot Abyss Jewels in the tests above, here is a new POB link which includes Abyss Jewels: And some tests that I ran:
|
Contributor
|
@michelrtm Hi, are you going to resolve branch conflict? |
|
Would love to see this get finished. Is there someone currently working on it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #6275 .
Description of the problem being solved:
When hovering on non-restricted (like timeless jewels) and non-cluster jewels in POB the tooltip that compares the benefits and drawbacks of adding the jewel to the build compares them to cluster jewels as well as per the image below:

Steps taken to verify a working solution:
Tooltip with option enabled.
Tooltip with option disabled.
Link to a build that showcases this PR:
https://pobb.in/fX8QA_1MH4ve
Before screenshot:
Cluster jewels present in tooltip.
After screenshot:
New option added to the options screen.
Cluster jewels no longer present in toolip.