Expose sceenshot funcitonality to lua. Remove screenshot hotkey.#65
Merged
Wires77 merged 1 commit intoPathOfBuildingCommunity:masterfrom Jan 19, 2025
Merged
Conversation
Wires77
approved these changes
Jan 19, 2025
Member
Wires77
left a comment
Wires77
left a comment
There was a problem hiding this comment.
Do you have a Lua-side PR for this also?
Contributor
Author
|
@Wires77 i'll make one. I remember testing it from lua. |
This was referenced Jan 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion regarding #64 on discord it had been suggested that it may be beneficial to handle the screenshot hotkey from lua.
This pr adds a new function available from lua,
TakeScreenshot, which allows for taking screenshots using the existing SimpleGraphic screenshot code. The hotkey to call the functionality directly inside of SG was removed as it was considered redundant.