Repository navigation
feat(desktop): drag tabs and panes between the main area and the sidebar #9530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -133,7 +133,10 @@ export function BrowserErrorOverlay({ | |
| }, [detailsText, copyToClipboard]); | ||
|
|
||
| return ( | ||
| <div className="pointer-events-auto absolute inset-0 z-10 flex items-center justify-center bg-background"> | ||
| <div | ||
| data-pointer-passthrough-target | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| className="pointer-events-auto absolute inset-0 z-10 flex items-center justify-center bg-background" | ||
| > | ||
| <div className="flex flex-col items-start gap-4 w-80"> | ||
| <GlobeIcon className="size-10 text-muted-foreground/30" /> | ||
| <div> | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,7 +40,11 @@ export function useBrowserOpenRequests() { | |
| [], | ||
| ); | ||
| } | ||
| const paneId = openBackgroundBrowser({ collections, ...request }); | ||
| const paneId = openBackgroundBrowser({ | ||
| collections, | ||
| workspaceId: request.workspaceId, | ||
| url: request.url, | ||
| }); | ||
|
Comment on lines
+43
to
+47
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| browserRuntimeRegistry.openBackground( | ||
| paneId, | ||
| request.url, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: ParadevAI/Paradev
Length of output: 10642
Script executed:
Repository: ParadevAI/Paradev
Length of output: 36144
Script executed:
Repository: ParadevAI/Paradev
Length of output: 29669
Script executed:
Repository: ParadevAI/Paradev
Length of output: 16714
Script executed:
Repository: ParadevAI/Paradev
Length of output: 7799
Web query:
react-dnd 16.0.1 react-dnd-html5-backend HTML5BackendImpl connectDropTarget addEventListener dragenter dragover drop source githubResult:
Script executed:
Repository: ParadevAI/Paradev
Length of output: 14010
Web query:
react-dnd-html5-backend@16.0.1 HTML5BackendImpl.ts connectDropTarget handleTopDragOver handleDrop addEventListenerResult:
Let browser overlays yield during tab and pane drags.
When the find bar or design-mode confirmation is open, its interactive portal can intercept a drag over the browser. The pane then cannot receive the drop or create the split. Make these overlays yield pointer input during native drags, including their interactive descendants.