Repository navigation
chore(skills): fix broken tool names, commands and paths across agent skills #9258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ Run the two fixers first, since they rewrite files the other checks read: | |
| Then run these three **in parallel** and report all results: | ||
|
|
||
| 3. `bun run typecheck` — TypeScript type checking across all packages | ||
| 4. `bun test` — Run all tests | ||
| 4. `bun run test` — Every package's suite through turbo, as CI runs it | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Prompt To Fix With AIThis is a comment left during a code review.
Path: .agents/commands/ci-check.md
Line: 18
Comment:
**Local checks skip terminal tests**
`bun run test` runs only the `test` task. CI also runs `test:integration:terminal`, which checks real terminal launches with Node. The updated instruction skips those suites while saying it runs tests as CI does, so an agent can report success before a terminal regression fails on push. Include `test:integration:terminal` in the command.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||
| 5. `bun run check:i18n` — Regenerates the translation catalogs and fails on missing or stale translations | ||
|
|
||
| ## Output | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
bun run testomits CI'stest:integration:terminaltask, despite claiming to mirror CI. Run both Turbo tasks here, or state that terminal integration tests are not included.Prompt for AI agents