Repository navigation
feat(api): group automations (setGroup, CLI --group, MCP group) #9209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { describe, expect, it } from "bun:test"; | ||
| import { | ||
| AUTOMATION_GROUP_MAX_LENGTH, | ||
| automationGroupInputSchema, | ||
| matchExistingAutomationGroup, | ||
| } from "./automation-group"; | ||
|
|
||
| describe("automationGroupInputSchema", () => { | ||
| it("trims and collapses whitespace, keeping case", () => { | ||
| expect(automationGroupInputSchema.parse(" Daily Ops ")).toBe( | ||
| "Daily Ops", | ||
| ); | ||
| }); | ||
|
|
||
| it("reads blank and null as ungrouped", () => { | ||
| expect(automationGroupInputSchema.parse(" ")).toBeNull(); | ||
| expect(automationGroupInputSchema.parse(null)).toBeNull(); | ||
| }); | ||
|
|
||
| it("rejects a name over the limit", () => { | ||
| const long = "x".repeat(AUTOMATION_GROUP_MAX_LENGTH + 1); | ||
| expect(automationGroupInputSchema.safeParse(long).success).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe("matchExistingAutomationGroup", () => { | ||
| it("reuses the existing spelling of a group", () => { | ||
| expect(matchExistingAutomationGroup("marketing", ["Marketing"])).toBe( | ||
| "Marketing", | ||
| ); | ||
| expect(matchExistingAutomationGroup("Support", ["Marketing"])).toBe( | ||
| "Support", | ||
| ); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { z } from "zod"; | ||
|
|
||
| export const AUTOMATION_GROUP_MAX_LENGTH = 64; | ||
|
|
||
| /** | ||
| * Trim and collapse inner whitespace. Returns null for empty input, which | ||
| * means "ungrouped". Case is kept: the group name is shown as typed. | ||
| */ | ||
| export function normalizeAutomationGroup( | ||
| group: string | null | undefined, | ||
| ): string | null { | ||
| if (group == null) return null; | ||
| const normalized = group.trim().replace(/\s+/g, " "); | ||
| return normalized.length === 0 ? null : normalized; | ||
| } | ||
|
|
||
| /** The existing group that matches `group` without regard to case, else `group`. */ | ||
| export function matchExistingAutomationGroup( | ||
| group: string, | ||
| existing: readonly string[], | ||
| ): string { | ||
| const lower = group.toLocaleLowerCase(); | ||
| return existing.find((name) => name.toLocaleLowerCase() === lower) ?? group; | ||
| } | ||
|
|
||
| export const automationGroupInputSchema = z | ||
| .string() | ||
| .transform(normalizeAutomationGroup) | ||
| .pipe(z.string().max(AUTOMATION_GROUP_MAX_LENGTH).nullable()) | ||
| .nullable(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing only the group through the CLI or MCP sends the new field through
automation.update. For an automation with several schedules, that procedure reads the soonest schedule and callssyncScheduleTrigger, which deletes the others. Users lose scheduled runs even though they requested no schedule change.Use
setGroupfor group-only edits, or skip schedule writes when schedule inputs are absent.Knowledge Base Used: API, SDK, and RPC contracts
Prompt To Fix With AI