Repository navigation
feat(desktop): open right-pane tools from the main + menu - #9019
Conversation
With the right pane on, the main area's + menu dropped Browser, Changes and Desktop, so the right-pane tools were hard to find. The menu now has an "Open in right pane" section with the same options as the right pane's New Tab (Terminal excluded: it already leads the menu and its shortcut opens in the main area).
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
[Low impact] The PR appears safe to merge, with no actionable issues found. SummaryThe main
No actionable issues found. Review was based on code inspection; no runtime or visual checks were performed. Reviews (1) · Last reviewed commit: "feat(desktop): open right-pane tools fro..." · Reviewed by Greptile |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
What & why
Feedback: with the right pane system on, the main area tab group's
+menu lost Browser, Changes and Desktop, which made the right pane hard to discover.The
+menu now has an "Open in right pane" section, after a separator and a muted label. It lists the same options as the right pane's New Tab (getRightPaneOptions): Browser, Changes, Files, Pages, plus Desktop (sandbox only) and Mobile (mobile-pane flag only). Each item adds a tab to the right pane and opens the pane. Changes reusesopenChanges, so it focuses an existing Changes tab instead of opening a second one.Terminal is left out of the section: it already leads the menu, and its shortcut opens in the main area. With the right pane off, the menu is unchanged.
The "Open in right pane" string was already translated in every locale, so the catalogs don't change.
How I tested it
bun run typecheck(desktop) passes; biome is clean on the changed files; the 72 tests under the workspacecomponents/folder pass;check:i18nreports nothing missing.AddTabMenuin the running dev app (CDP) with the propspage.tsxpasses when the right pane is on, and checked the layout:Checklist
type(scope): subject)bun run lintandbun run typecheckpass (CI fails on lint warnings too)Summary by cubic
Adds an "Open in right pane" section to the main area's
+menu so right-pane tools are discoverable when the right pane is enabled.getRightPaneOptionslist, so the main menu matches the right pane's New Tab: Browser, Changes, Files, Pages, and Desktop/Mobile where applicable.openChanges, focusing an existing Changes tab instead of opening a duplicate.Written for commit eecda7f. Summary will update on new commits.
Summary by CodeRabbit