Skip to content

feat(desktop): open right-pane tools from the main + menu - #9019

Merged
saddlepaddle merged 1 commit into
mainfrom
superset/cloud-workspace-bdbeeec2
Oct 28, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
superset/cloud-workspace-bdbeeec2

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

What & why

Feedback: with the right pane system on, the main area tab group's + menu lost Browser, Changes and Desktop, which made the right pane hard to discover.

The + menu now has an "Open in right pane" section, after a separator and a muted label. It lists the same options as the right pane's New Tab (getRightPaneOptions): Browser, Changes, Files, Pages, plus Desktop (sandbox only) and Mobile (mobile-pane flag only). Each item adds a tab to the right pane and opens the pane. Changes reuses openChanges, so it focuses an existing Changes tab instead of opening a second one.

Terminal is left out of the section: it already leads the menu, and its shortcut opens in the main area. With the right pane off, the menu is unchanged.

The "Open in right pane" string was already translated in every locale, so the catalogs don't change.

How I tested it

  • bun run typecheck (desktop) passes; biome is clean on the changed files; the 72 tests under the workspace components/ folder pass; check:i18n reports nothing missing.
  • Rendered the real AddTabMenu in the running dev app (CDP) with the props page.tsx passes when the right pane is on, and checked the layout:
Terminal                Ctrl+Shift+T
Chat                    Ctrl+Alt+Shift+J
──────────────────────
Open in right pane
Browser                 Ctrl+Alt+Shift+B
Changes                 Ctrl+Alt+Shift+G
Files
Pages
Desktop
Mobile
──────────────────────
✓ Show Scripts Bar
  • Not tested: clicking the items from a real workspace tab bar. The cloud sandbox's dev app couldn't open any workspace (the local relay was unreachable).

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (CI fails on lint warnings too)
  • "Allow edits from maintainers" is checked on fork PRs
  • I have signed the CLA (the bot asks on your first PR)

Summary by cubic

Adds an "Open in right pane" section to the main area's + menu so right-pane tools are discoverable when the right pane is enabled.

  • Reuses the existing getRightPaneOptions list, so the main menu matches the right pane's New Tab: Browser, Changes, Files, Pages, and Desktop/Mobile where applicable.
  • Excludes Terminal, since it already leads the menu and its shortcut targets the main area.
  • Changes reuses openChanges, focusing an existing Changes tab instead of opening a duplicate.
  • Leaves the menu unchanged when the right pane is off.

Written for commit eecda7f. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • New Features
    • The Add Tab menu now includes an “Open in right pane” section when right-pane options are available.
    • Choose an option to open changes or another supported view in the right pane. Available options adjust to workspace settings.
    • Option labels are localized, and hotkeys are displayed when available.

With the right pane on, the main area's + menu dropped Browser, Changes
and Desktop, so the right-pane tools were hard to find. The menu now has
an "Open in right pane" section with the same options as the right
pane's New Tab (Terminal excluded: it already leads the menu and its
shortcut opens in the main area).
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The workspace add-tab menu now lists eligible right-pane options. Selecting an option opens changes for the diff option or creates a right-pane tab for other options.

Changes: Right-pane menu

Layer / File(s) Summary
Add right-pane options to the menu
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/AddTabMenu/AddTabMenu.tsx
The menu accepts optional right-pane options and a selection handler. It displays translated labels and any provided hotkeys.
Build and handle workspace options
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/index.ts, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/page.tsx
The workspace builds eligible options and handles selections by opening changes or creating a right-pane tab. It passes the options and handler to the menu.

Priority: Not assessed

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant AddTabMenu
  participant V2WorkspaceContent
  participant rightStore
  User->>AddTabMenu: Select a right-pane option
  AddTabMenu->>V2WorkspaceContent: Call onOpenInRightPane with kind
  alt kind is diff
    V2WorkspaceContent->>V2WorkspaceContent: Call openChanges
  else other kind
    V2WorkspaceContent->>rightStore: Create and add right-pane tab
    V2WorkspaceContent->>V2WorkspaceContent: Open sidebar
  end
Loading

Suggested reviewers: kitenite

Merge Risk: Minimal · up to eecda

The new menu paths select and reveal their requested tabs. No merge-blocking risk was identified.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge, with no actionable issues found.

Summary

The main + menu gains an “Open in right pane” section.

  • The workspace + menu opens eligible tools in the right pane.

No actionable issues found. Review was based on code inspection; no runtime or visual checks were performed.

Reviews (1) · Last reviewed commit: "feat(desktop): open right-pane tools fro..." · Reviewed by Greptile

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit 3055296 into main Oct 28, 2026
17 of 18 checks passed

This branch was previously deployed

1 inactive deployment
preview — eecda7f4 Deployed Oct 28, 2026 by saddlepaddle via Deploy Marketing #13088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant