Skip to content

feat(desktop): stop offering Review as a right-pane type - #8958

Merged
saddlepaddle merged 1 commit into
mainfrom
superset/right-pane-remove-review-pane-type-bad27b02
Oct 28, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
superset/right-pane-remove-review-pane-type-bad27b02

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

From Satya's right-pane audit (#general, 2026-10-27): Review shouldn't be a generic pane type in the right pane.

Change

Removed the Review tile from the right pane's New Tab "Tools" list (RightPaneNewTab/paneOptions.ts, RightPaneKind, createRightPane).

Nothing else changes:

  • Clicking a PR still opens a pull-request pane for that PR in the right pane area. That covers the New Tab's "Pull requests" list, the toolbar PR badge, and the sidebar PR chip.
  • The review pane renderer stays registered, so saved layouts that already hold one still render.

Rebased onto main after #8965 (New Tab screen), which replaced the add menu and empty state this PR first edited. The empty-state "Pull request #N" button from the first version is gone: that empty state no longer exists, and the New Tab's PR list covers it.

Validation

  • tsc --noEmit (desktop): pass
  • biome check on RightPaneNewTab: clean
  • bun test for RightPaneNewTab, RightPaneArea and useRightPaneAreaLifecycle: 7 pass. The option list assertions now exclude review.
  • bun run check:i18n: 0 missing in every locale
  • Not checked in the running app, and no screenshots.

Summary by CodeRabbit

  • Changes
    • The Review option is no longer available when choosing a pane to open in a workspace’s right pane. Other pane options remain available.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5d5a5106-62fd-493a-a779-0db7be140a1f
Commits

Reviewing files that changed from the base of the PR and between 84f9a90 and 244b33a.

Files selected for processing: 3
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/paneOptions.test.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/paneOptions.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/types.ts
Files with no reviewable changes: 2
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/types.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/paneOptions.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The right-pane options no longer include the Review pane. The RightPaneKind union, option list, pane creation switch, and related test expectations were updated.

Changes: Right-pane option removal

Layer / File(s) Summary
Remove Review pane from options
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/types.ts, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/paneOptions.ts, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/paneOptions.test.ts
The RightPaneKind union, option list, and createRightPane no longer include "review". Tests now expect the remaining pane kinds.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: harshithmullapudi

Merge Risk: Minimal · up to 244b3

The Review pane was removed from new-pane options while saved Review layouts remain supported.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly summarizes the main change and follows the repository's conventional commit format.
Description check Passed The description explains the change, affected behavior, compatibility with saved layouts, and validation results. It does not include the template's Checklist section, but the required technical conte…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change, affected behavior, compatibility with saved layouts, and validation results. It does not include the template's Checklist section, but the required technical context is otherwise mostly complete.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

Remove Review from the right pane's add menu and empty state. The PR pane
stays reachable from the toolbar PR badge, the sidebar PR chip, and a new
contextual 'Pull request #N' button in the right pane empty state, shown
when the workspace has a linked PR. The review pane renderer stays so
persisted layouts that hold one still render.
@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Removes Review from the right pane’s New Tab tools without removing support for saved Review panes.

  • The right-pane New Tab no longer offers Review as a tool.

Reviews (1) · Last reviewed commit: "feat(desktop): stop offering Review as a..." · Reviewed by Greptile

@saddlepaddle
saddlepaddle merged commit 7f4d794 into main Oct 28, 2026
18 checks passed
@saddlepaddle
saddlepaddle deleted the superset/right-pane-remove-review-pane-type-bad27b02 branch October 28, 2026 17:17

This branch was previously deployed

1 inactive deployment
preview — 244b33ab Deployed Oct 28, 2026 by saddlepaddle via Deploy API #13045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant