Repository navigation
feat(desktop): stop offering Review as a right-pane type - #8958
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Remove Review pane from options apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/types.ts, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/paneOptions.ts, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/RightPaneNewTab/paneOptions.test.ts |
The RightPaneKind union, option list, and createRightPane no longer include "review". Tests now expect the remaining pane kinds. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: harshithmullapudi
Merge Risk: 
Minimal · up to 244b3
-
The Review pane was removed from new-pane options while saved Review layouts remain supported.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Description check
-
Explanation
The description explains the change, affected behavior, compatibility with saved layouts, and validation results. It does not include the template's Checklist section, but the required technical context is otherwise mostly complete.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Remove Review from the right pane's add menu and empty state. The PR pane stays reachable from the toolbar PR badge, the sidebar PR chip, and a new contextual 'Pull request #N' button in the right pane empty state, shown when the workspace has a linked PR. The review pane renderer stays so persisted layouts that hold one still render.
0cea504 to
244b33a
Compare
[Low impact] The PR appears safe to merge. SummaryRemoves Review from the right pane’s New Tab tools without removing support for saved Review panes.
Reviews (1) · Last reviewed commit: "feat(desktop): stop offering Review as a..." · Reviewed by Greptile |
From Satya's right-pane audit (#general, 2026-10-27): Review shouldn't be a generic pane type in the right pane.
Change
Removed the Review tile from the right pane's New Tab "Tools" list (
RightPaneNewTab/paneOptions.ts,RightPaneKind,createRightPane).Nothing else changes:
pull-requestpane for that PR in the right pane area. That covers the New Tab's "Pull requests" list, the toolbar PR badge, and the sidebar PR chip.reviewpane renderer stays registered, so saved layouts that already hold one still render.Rebased onto main after #8965 (New Tab screen), which replaced the add menu and empty state this PR first edited. The empty-state "Pull request #N" button from the first version is gone: that empty state no longer exists, and the New Tab's PR list covers it.
Validation
tsc --noEmit(desktop): passbiome checkonRightPaneNewTab: cleanbun testfor RightPaneNewTab, RightPaneArea and useRightPaneAreaLifecycle: 7 pass. The option list assertions now excludereview.bun run check:i18n: 0 missing in every localeSummary by CodeRabbit