fix(marketing): skip the API read for a malformed fight handle by superset-home · Pull Request #8817 · ParadevAI/Paradev

superset-home · 2026-10-23T15:07:29Z

Problem

/fight?a=…&b=… failed to render when a query value was not a valid leaderboard handle, for example a handle with a trailing ) from a pasted link. The server render threw an unhandled tRPC input-validation error.

Root cause

resolveFighter sent the raw query value to leaderboard.public.participant. That procedure's handleSchema refuses anything outside HANDLE_PATTERN, or a reserved handle, with BAD_REQUEST. fetchParticipant returns null only for NOT_FOUND and rethrows all other errors, so the render failed. #7295 fixed the same problem for profile routes: there the proxy routes to a profile only when isProfileHandle passes. The fight page had no such check.

Fix

Use the same isProfileHandle check in resolveFighter before the API read. If the handle is not valid, that slot is empty, which is what a missing profile already shows.

Verification

$ bunx biome check "src/app/[lang]/fight/page.tsx"
Checked 1 file in 32ms. No fixes applied.

$ cd apps/marketing && bun run typecheck
$ tsc --noEmit
(no errors)

$ bun test "src/app/[lang]/fight"
 11 pass
 0 fail
Ran 11 tests across 1 file.

Refs MARKETING-6C

Summary by cubic

Fixes the /fight page render failing when a query value is not a valid leaderboard handle. resolveFighter sent the raw value to leaderboard.public.participant, which rejects malformed handles (like pasted links with a trailing )) with BAD_REQUEST; fetchParticipant rethrows everything except NOT_FOUND, so the page crashed.

The page now uses the same isProfileHandle check used for profile routes before the API read. Invalid handles render as an empty slot, matching the missing-profile state.

^{Written for commit a102ea1. Summary will update on new commits.}

Summary by CodeRabbit

Bug Fixes
- Invalid fighter profile handles are now rejected before participant details load, preventing malformed handles from appearing as valid fighters.
- House fighters continue to be resolved first.

The fight page sent the raw ?a= and ?b= values to leaderboard.public.participant. A value the handle schema refuses came back as BAD_REQUEST, which fetchParticipant rethrows, so the page render failed. Check the handle with isProfileHandle, the same check the proxy uses for profile routes, and show an empty slot. Refs MARKETING-6C

coderabbitai · 2026-10-23T15:07:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 93107686-3267-4998-81dc-68ee26d3583f

📥 Commits

Reviewing files that changed from the base of the PR and between cf94352 and a102ea1.

📒 Files selected for processing: 1

apps/marketing/src/app/[lang]/fight/page.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Fighter resolution now rejects normalized handles that fail isProfileHandle before participant lookup. House fighters are still checked first.

Changes: Fighter resolution

Layer / File(s)	Summary
Validate normalized handles `apps/marketing/src/app/[lang]/fight/page.tsx`	`resolveFighter` imports `isProfileHandle` and returns `null` for invalid normalized handles after checking house fighters.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: kitenite

Merge Risk: ⚪ Minimal · up to a102e

Malformed fight handles now avoid the failing API request and render with an empty slot; no merge-blocking risk remains.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title follows conventional commit format and names the primary change: the fight page now skips the API read for a malformed handle. It matches the raw summary, which shows resolveFighter rejectin…
Description check		The description covers the problem, root cause, fix, and verification. It gives a clear account of the failure path and the change. It does not fill the template's 'How I tested it' section with scree…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title follows conventional commit format and names the primary change: the fight page now skips the API read for a malformed handle. It matches the raw summary, which shows resolveFighter rejecting handles that fail isProfileHandle before loading a participant. The title is specific and accurate.

Full details: Description check

Explanation

The description covers the problem, root cause, fix, and verification. It gives a clear account of the failure path and the change. It does not fill the template's 'How I tested it' section with screenshots, and the checklist items are not marked. The 'What & why' section does not link an issue, but it references MARKETING-6C and #7295. Those gaps are minor, so the description is mostly complete.

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

greptile-apps · 2026-10-23T15:09:58Z

Confidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

The fight page now checks query handles before fetching a participant.

Invalid fight handles leave their fighter slots empty.

_{Reviews (1) · Last reviewed commit: "fix(marketing): skip the API read for a ..." · Reviewed by Greptile}

github-actions · 2026-10-23T15:11:45Z

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

✅ Neon database branch

Thank you for your contribution! 🎉

superset-home temporarily deployed to preview October 23, 2026 15:07 — with GitHub Actions Inactive

superset-home merged commit 60d38e2 into main Oct 23, 2026
17 checks passed

Navigation Menu

Repository navigation

fix(marketing): skip the API read for a malformed fight handle - #8817

fix(marketing): skip the API read for a malformed fight handle#8817
superset-home merged 1 commit into
mainfrom
sentry/marketing-6c-fight-invalid-handle

superset-home commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

superset-home commented Oct 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Root cause

Fix

Verification

Summary by cubic

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

github-actions Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧹 Preview Cleanup Complete

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

superset-home commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

greptile-apps Bot commented Oct 23, 2026 •

edited

Loading

github-actions Bot commented Oct 23, 2026 •

edited

Loading