Repository navigation
refactor(desktop): remove the new-sidebar experiment and its legacy path - #8790
Merged
Merged
Conversation
The new sidebar is now the only sidebar: cloud workspaces sit under their projects, the local/cloud filter shows whenever cloud workspaces are on, and every workspace uses the redesigned row. Removes the Experimental toggle, its settings-search entry and persisted store (key moved to DEAD_KEYS), the sidebar-inline-cloud-workspaces flag, the standalone Cloud section, the legacy workspace row, and the header's Cloud workspaces / Projects links that only the legacy sidebar showed.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 5 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly describes the main change: removing the new-sidebar experiment and its legacy rendering path. It follows the required conventional commit format. Description check The description is detailed and covers the change, rationale, implementation, behavior changes, testing, known typecheck baseline failures, and follow-ups. It uses equivalent headings instead of the t… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description is detailed and covers the change, rationale, implementation, behavior changes, testing, known typecheck baseline failures, and follow-ups. It uses equivalent headings instead of the template headings, but it is mostly complete and relevant.
-
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Contributor
 [Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryMakes the redesigned desktop sidebar the only sidebar.
No actionable issues found. Runtime UI checks were not performed. Acknowledgments from Kitenite:
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Cloud workspace flag] --> B[useCloudWorkspaces]
B --> C[Visible cloud rows]
C --> D[Project placements]
E[Local workspace placements] --> F[Sidebar projects and pinned rows]
D --> F
F --> G[DashboardSidebarExpandedWorkspaceRow]
Reviews (1) · Last reviewed commit: "refactor(desktop): remove the new-sideba..." · Reviewed by Greptile |
Contributor
|
Review verdict: minor issues. The removal is complete and works in the running desktop app at
I did not run the cloud-flag-off path (the flag comes from PostHog) or the collapsed rail. Full report with screenshots: https://app.superset.sh/page/pr-8790-review-remove-new-sidebar-experiment-fzhjvm |
|
Preview update published for development build |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sidebar-inline-cloud-workspacesPostHog flag are gone, along with everything only the off side rendered.Why / Context
The experiment is concluded. Keeping both paths meant two workspace rows, two cloud layouts and a header that changed shape depending on a local toggle.
How It Works
useDashboardSidebarDataandTagFolderWorkspacesProvideralways take the inline-cloud path.useCloudWorkspacesalready returns[]whencloud-workspacesis off, so without cloud the cloud layout is empty andapplyCloudSidebarRows/applyCloudSidebarPinnedRowspass the rows through unchanged.cloud-workspacesdirectly, which is the only remaining gate.DashboardSidebarWorkspaceItemalways rendersDashboardSidebarExpandedWorkspaceRow. The header drops the Cloud workspaces / Projects links that only the legacy sidebar showed.stores/new-dashboard-sidebar.ts(its keynew-dashboard-sidebarmoves toDEAD_KEYSso the boot sweep clears it)hooks/useNewDashboardSidebarEnabledand its contextDashboardSidebarCloudSection/**DashboardSidebarLegacyExpandedWorkspaceRowEXPERIMENTAL_NEW_SIDEBARsettings entryFEATURE_FLAGS.SIDEBAR_INLINE_CLOUD_WORKSPACESBehavior changes
/cloud-workspacesand/projectsroutes still exist.Manual QA Checklist
Checked end-to-end in this branch's dev desktop app (renderer on :8325), with real mouse input over CDP:
cloud-workspaces: false): the "Show" section leaves the menu, the cloud row goes, and the projects and rows render normallynew-dashboard-sidebar = {enabled:false}and reloading: the key is cleared by the boot sweep, and the new sidebar still rendersTesting
bunx biome checkon changed files: cleanbun testfor persisted-keys, openPullRequestLink, DashboardSidebar and settings: 329 passbun run check:i18n: passesbun run typecheck(desktop): 27 errors, all better-auth typings inpackages/auth/packages/trpcand auth-session call sites. The base commit8cd20d0b8ahas the same 27; none are in files this PR touches.Follow-ups
sidebar-inline-cloud-workspacesflag in PostHog.cloudSidebarStoregroup actions (createGroup,renameGroup,deleteGroup,moveToGroup,toggleGroupCollapsed,markUnread) have no callers now.useNavigateAwayFromWorkspacestill orders siblings with the old Cloud-section groups first, so after removing the open workspace it can pick the wrong next one. This already happened with the new sidebar on; it is left out of this PR to keep it focused.Summary by cubic
The new-sidebar experiment is concluded: the redesigned sidebar (cloud workspaces under their projects, host filter, redesigned workspace row) is now the only sidebar. Removes the "New sidebar" toggle in Settings › Experimental, the
sidebar-inline-cloud-workspacesflag, the standalone Cloud section, and the legacy workspace row, deleting ~5.2k lines across 75 files.Behavior changes
/cloud-workspacesand/projectsroutes still exist.new-dashboard-sidebarlocalStorage key moves toDEAD_KEYSso the boot sweep clears it.Follow-ups
sidebar-inline-cloud-workspacesflag in PostHog.cloudSidebarStoregroup actions no longer have callers.useNavigateAwayFromWorkspacestill orders old Cloud-section groups first, so it can pick the wrong next workspace after closing one.Written for commit e1d0224. Summary will update on new commits.
Summary by CodeRabbit