Repository navigation
Conversation
…lve Dependabot alerts
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
Found 1 test failure on Blacksmith runners: Failure
|
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
|
Preview update published for development build |
[Medium impact] The PR appears safe to merge; no actionable regression was found. SummaryUpdates dependencies to address the listed Dependabot alerts.
Review checks were limited to source and lockfile inspection. No install, build, typecheck, or Storybook smoke test was run. Acknowledged scope and existing issues:
Reviews (1) · Last reviewed commit: "fix(deps): bump storybook, @modelcontext..." · Reviewed by Greptile |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
Bumps dependencies to patched versions. Also raises the root
overridesfor@modelcontextprotocol/sdk(1.31.0 → 1.32.0) andhono(4.13.7 → 4.13.11); without it the override would pin every workspace to the vulnerable version.Closes Dependabot alerts:
storybook → 10.6.2 (with
@storybook/*packages on the same version) inpackages/ui,apps/desktop,apps/mobile@modelcontextprotocol/sdk → 1.32.0 in
packages/cli,apps/docs,apps/apihono → 4.13.11 in
packages/host-service,apps/relay,apps/realtimeserveStaticdecodes the request path a second time, leading to bypass of middleware on static pathsNot included, already covered by open Dependabot PRs: #8695 (hono usercontent), #8693/#8696 (MCP SDK trpc/mcp), #8738/#8694 (vite), #8739 (electron 41 → 42 major), #8740 (storybook chat-ui). Those PRs will conflict with the root override bump on rebase.
Test plan
bun install(lockfile refreshed)bun run lint:fixcleanbun run typecheckpasses in apps/api, apps/desktop, apps/docs, apps/relay, apps/realtime, packages/cli, packages/host-service, packages/uiunrefonnumberin packages/port-scanner and packages/workspace-fs); not caused by this changeSummary by cubic
Bumps
storybookto 10.6.2,@modelcontextprotocol/sdkto 1.32.0, andhonoto 4.13.11 across affected workspaces to resolve Dependabot alerts. Also raises the rootoverridesfor@modelcontextprotocol/sdkandhonoto the patched versions; without this, the override would pin every workspace to the vulnerable version.What each bump fixes
storybook10.6.2 (packages/ui,apps/desktop,apps/mobile): closes a critical missing origin validation in the Storybook preview that allowed code injection from malicious sites.@modelcontextprotocol/sdk1.32.0 (packages/cli,apps/docs,apps/api): fixes memory exhaustion during validation, bearer tokens accepted across services, experimental tasks not tied to their creating session, and cross-origin redirects in HTTP client transports and OAuth requests.hono4.13.11 (packages/host-service,apps/relay,apps/realtime): fixesserveStaticdouble-decoding the request path, which let requests bypass middleware on static paths.Lockfile refreshed; lint and typecheck pass except in
apps/mobile, which fails with the same 12 pre-existing errors as unmodified main. Open Dependabot PRs for related upgrades (electron 42, vite, MCP SDK trpc/mcp, storybook chat-ui) are kept separate and will conflict with the root override bump on rebase.Written for commit 8b02d72. Summary will update on new commits.
Summary by CodeRabbit