Repository navigation
chore: move bun to 1.4.3 everywhere and drop the canary test step - #8667
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly describes the primary changes: updating Bun to 1.4.3 and removing the canary test step. It uses conventional commit format. |
| Description check | |
The description explains the changes, motivation, testing performed, and known test flake. It does not include the template's Checklist section, but the required change and verification details are ot… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description explains the changes, motivation, testing performed, and known test flake. It does not include the template's Checklist section, but the required change and verification details are otherwise complete.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
No installed development build can load this pull request as an update: its native fingerprint is |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
 [Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates Bun and its type packages to 1.4.3 across the repository.
No actionable issues were found. Tests and fingerprint comparisons were not run during this review. Reviews (1) · Last reviewed commit: "chore: move bun to 1.4.3 everywhere and ..." · Reviewed by Greptile |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔇 Additional comments: 51
.bun-version: 1
1-1: LGTM!package.json: 1
9-9: LGTM!Also applies to: 22-22
apps/desktop/package.json: 1
273-273: LGTM!apps/marketing/package.json: 1
73-73: LGTM!apps/web/package.json: 1
58-58: LGTM!packages/agent-setup/package.json: 1
38-38: LGTM!packages/chat-runtime/package.json: 1
34-34: LGTM!packages/chat/package.json: 1
37-37: LGTM!packages/cli-framework/package.json: 1
20-20: LGTM!packages/cli/package.json: 1
40-40: LGTM!packages/cloud-client/package.json: 1
29-29: LGTM!packages/db/package.json: 1
58-58: LGTM!packages/email/package.json: 1
10-10: LGTM!packages/host-client/package.json: 1
21-21: LGTM!packages/host-service/package.json: 1
119-119: LGTM!packages/i18n/package.json: 1
71-71: LGTM!packages/local-db/package.json: 1
35-35: LGTM!packages/mcp/package.json: 1
37-37: LGTM!packages/panes/package.json: 1
26-26: LGTM!packages/port-scanner/package.json: 1
23-23: LGTM!packages/pty-daemon/package.json: 1
52-52: LGTM!packages/sandbox/package.json: 1
27-27: LGTM!packages/sdk/package.json: 1
42-42: LGTM!packages/shared/package.json: 1
460-460: LGTM!packages/ui/package.json: 1
109-109: LGTM!packages/workspace-client/package.json: 1
36-36: LGTM!packages/workspace-fs/package.json: 1
48-48: LGTM!apps/mobile/.eas/workflows/build-pr.yml: 1
10-10: LGTM!apps/mobile/.eas/workflows/deploy.yml: 1
19-19: LGTM!apps/mobile/.eas/workflows/e2e-ios.yml: 1
11-11: LGTM!apps/mobile/.eas/workflows/pr-preview.yml: 1
19-19: LGTM!apps/mobile/.eas/workflows/update-production.yml: 1
12-12: LGTM!apps/mobile/eas.json: 1
8-8: LGTM!Also applies to: 24-24, 33-33, 44-44
DEVELOPMENT.md: 1
9-9: LGTM!README.md: 1
254-254: LGTM!readme/README.cs.md: 1
289-289: LGTM!readme/README.de.md: 1
289-289: LGTM!readme/README.es.md: 1
289-289: LGTM!readme/README.id.md: 1
289-289: LGTM!readme/README.it.md: 1
289-289: LGTM!readme/README.ja.md: 1
284-284: LGTM!readme/README.ko.md: 1
284-284: LGTM!readme/README.nl.md: 1
289-289: LGTM!readme/README.pl.md: 1
290-290: LGTM!readme/README.pt-BR.md: 1
289-289: LGTM!readme/README.ru.md: 1
290-290: LGTM!readme/README.tr.md: 1
289-289: LGTM!readme/README.vi.md: 1
289-289: LGTM!readme/README.zh-CN.md: 1
284-284: LGTM!readme/README.zh-TW.md: 1
284-284: LGTM!readme/README.fr.md-289-289: 1
289-289: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Use a typographic apostrophe in the French prerequisite sentence.
Replace
qu'exécutewithqu’exécute. LanguageTool flags the ASCII apostrophe in this changed line.Source: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
- Configuration used: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
fd5da7d6-365f-4d5a-a017-e55bf5854e2a
⛔ Files ignored due to path filters: 1
bun.lockis excluded by!**/*.lock
📒 Files selected for processing: 52
.bun-version.github/workflows/ci.ymlDEVELOPMENT.mdREADME.mdapps/desktop/package.jsonapps/marketing/package.jsonapps/mobile/.eas/workflows/build-pr.ymlapps/mobile/.eas/workflows/deploy.ymlapps/mobile/.eas/workflows/e2e-ios.ymlapps/mobile/.eas/workflows/pr-preview.ymlapps/mobile/.eas/workflows/update-production.ymlapps/mobile/eas.jsonapps/web/package.jsonpackage.jsonpackages/agent-setup/package.jsonpackages/chat-runtime/package.jsonpackages/chat/package.jsonpackages/cli-framework/package.jsonpackages/cli/package.jsonpackages/cloud-client/package.jsonpackages/db/package.jsonpackages/email/package.jsonpackages/host-client/package.jsonpackages/host-service/package.jsonpackages/i18n/package.jsonpackages/local-db/package.jsonpackages/mcp/package.jsonpackages/panes/package.jsonpackages/port-scanner/package.jsonpackages/pty-daemon/package.jsonpackages/sandbox/package.jsonpackages/sdk/package.jsonpackages/shared/package.jsonpackages/ui/package.jsonpackages/workspace-client/package.jsonpackages/workspace-fs/package.jsonreadme/README.cs.mdreadme/README.de.mdreadme/README.es.mdreadme/README.fr.mdreadme/README.id.mdreadme/README.it.mdreadme/README.ja.mdreadme/README.ko.mdreadme/README.nl.mdreadme/README.pl.mdreadme/README.pt-BR.mdreadme/README.ru.mdreadme/README.tr.mdreadme/README.vi.mdreadme/README.zh-CN.mdreadme/README.zh-TW.md
💤 Files with no reviewable changes: 1
- .github/workflows/ci.yml
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.
1.4.3 contains oven-sh/bun#44581, the synchronous-spawn fix the CI Test job has been taking from a pinned canary since #8311. Tests now run on the same bun as installs, builds and the shipped CLI. Moves .bun-version, packageManager, @types/bun and bun-types, the EAS build profiles and workflows, and the documented minimum. The lockfile change is only the type packages. A fresh install of the same lockfile under 1.4.2 and 1.4.3 gives identical store paths and the same mobile fingerprint, so the runtime version is unchanged.
3e3aaf8 to
a9ad499
Compare
Merges upstream main into the watcher build. Upstream moved to bun 1.4.3, which has the synchronous-spawn fix, and dropped its canary test step (ParadevAI#8667), so the fork workflow drops it too. Claude-Session: https://claude.ai/code/session_01CZBCrRCZ2rEBHv4DH3Wh3k
#8747) Since the bun 1.4.3 bump (#8667) the Test job has died four times in ~230 runs, always ~30 s into the step: three times the runner vanished with every step left unfinished, once node's test:integration:terminal was SIGKILLed (exit 137) while 26 of 29 tasks had already passed. The re-runs pass, and no test failed in any of them. The existing diagnostic only fires after a 345 s hang, so a kill at 30 s leaves nothing to read. Sample free memory and load every 2 s from the start of the step, and on failure print the last samples plus the kernel's OOM-kill lines, so the next death says whether the 32 GB runner ran out of memory or the VM was taken away.
What
.bun-version,packageManager, every@types/bunandbun-typespin, the EAS build profiles and EAS workflows: 1.4.2 to 1.4.3.bun@1.4.2-canary.20261007.1(ci: run tests on a bun build that has the spawnSync fix #8311). 1.4.3 contains the synchronous-spawn fix (spawnSync: stop pointing the VM at the loop it waits on oven-sh/bun#44581), so tests run on the same bun as everything else again.README.md,DEVELOPMENT.mdand the translated readmes moves to v1.4.3+.bun.lockchanges only the bun type packages.Checked
terminal disposal cleans up background process groups) timed out under load in the full run, then passed five times alone, alternating 1.4.3 and 1.4.2.node_modules/.bunlisting (2,808 entries) and the same iOS fingerprint, so existing builds keep receiving updates.Summary by cubic
Moves the repo to bun 1.4.3 everywhere:
.bun-version,packageManager, all@types/bunandbun-typespins, the EAS build profiles and workflows, and the documented minimum in the READMEs andDEVELOPMENT.md. Drops the CI Test job step that installed a bun canary, since 1.4.3 contains the synchronous-spawn fix (oven-sh/bun#44581) the canary was providing, so tests now run on the same bun as installs and builds.Verification
bun.lockchanges only the bun type packages.Written for commit a9ad499. Summary will update on new commits.
Summary by CodeRabbit
Chores
Documentation